Skip to content

Fix Fuchsia build broken by #124210 #124530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Apr 30, 2024
Merged

Fix Fuchsia build broken by #124210 #124530

bors merged 1 commit into from
Apr 30, 2024

Conversation

@djkoloski
Copy link
Contributor

@djkoloski djkoloski commented Apr 29, 2024

Fuchsia doesn't support dirfd although we have a symbol stubbed for it.

@djkoloski
Fix Fuchsia build broken by rust-lang#124210
982a58e 
Fuchsia doesn't support dirfd although we have a symbol stubbed for it.
@rustbot
Copy link
Collaborator

rustbot commented Apr 29, 2024

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 29, 2024
@djkoloski
Copy link
Contributor Author

djkoloski commented Apr 29, 2024

r? @tmandry

@rustbot rustbot assigned tmandry and unassigned ChrisDenton Apr 29, 2024
@tmandry
Copy link
Member

tmandry commented Apr 29, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 29, 2024

📌 Commit 982a58e has been approved by tmandry

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 29, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 29, 2024
@bors
Auto merge of rust-lang#124537 - matthiaskrgr:rollup-zjv9gu8, r=matth…
7823bf0 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#124185 (Remove optionality from MoveData::base_local)
 - rust-lang#124488 (Add a note to the ArbitraryExpressionInPattern error)
 - rust-lang#124530 (Fix Fuchsia build broken by rust-lang#124210)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d94eaba into rust-lang:master Apr 30, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2024
@rust-timer
Unrolled build for rust-lang#124530
1b6eb52 
Rollup merge of rust-lang#124530 - djkoloski:fuchsia_dirfd, r=tmandry

Fix Fuchsia build broken by rust-lang#124210

Fuchsia doesn't support dirfd although we have a symbol stubbed for it.
@rustbot rustbot added this to the 1.80.0 milestone Apr 30, 2024
@workingjubilee workingjubilee added the O-fuchsia Operating system: Fuchsia label May 4, 2024
@the8472 the8472 mentioned this pull request Sep 30, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tmandry tmandry

Labels

O-fuchsia Operating system: Fuchsia O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.80.0

Development

Successfully merging this pull request may close these issues.

6 participants

@djkoloski @rustbot @tmandry @bors @ChrisDenton @workingjubilee