-
Notifications
You must be signed in to change notification settings - Fork 14.1k
library: Rename IterRange* to Range*Iter
#149547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
This comment has been minimized.
This comment has been minimized.
199cebb to
6c51fb1
Compare
13 tasks
There is a weak convention in the ecosystem that `IterFoos` is an iterator yielding items of type `Foo` (e.g. `bitflags` `IterNames`, `hashbrown` `IterBuckets`), while `FooIter` is an iterator over `Foo` from an `.iter()` or `.into_iter()` method (e.g. `memchr` `OneIter`, `regex` `SetMatchesIter`). Rename `IterRange`, `IterRangeInclusive`, and `IterRangeFrom` to `RangeIter`, `RangeInclusiveIter`, and `RangeInclusiveIter` to match this. Tracking issue: RUST-125687 (`new_range_api`)
6c51fb1 to
bb239c2
Compare
Contributor
Author
|
(accepted by libs-api in #125687 (comment)) |
Member
|
@bors r+ rollup |
Collaborator
bors
added a commit
that referenced
this pull request
Dec 5, 2025
Rollup of 11 pull requests Successful merges: - #148662 (alloc: Document panics when allocations will exceed max) - #148811 (core docs: rewrite `panic::Location::caller` with visual line/column numbers) - #149101 (Improve mutable-binding suggestion to include name) - #149477 (float::maximum/minimum: make docs more streamlined) - #149547 (library: Rename `IterRange*` to `Range*Iter`) - #149548 (Generate delegation error body when delegation is not resolved) - #149630 (Check identifiers defined in macros when suggesting identifiers hidden by hygiene) - #149647 (Add regression test for 141845) - #149661 (Fix for LLVM22 making lowering decisions dependent on RuntimeLibraryInfo.) - #149666 (Add perma-unstable `--print=backend-has-zstd` for use by compiletest) - #149671 (interpret: test SNaN handling of float min/max and update comments) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Dec 5, 2025
Rollup merge of #149547 - tgross35:range-iterators, r=joboet library: Rename `IterRange*` to `Range*Iter` There is a weak convention in the ecosystem that `IterFoos` is an iterator yielding items of type `Foo` (e.g. `bitflags` `IterNames`, `hashbrown` `IterBuckets`), while `FooIter` is an iterator over `Foo` from an `.iter()` or `.into_iter()` method (e.g. `memchr` `OneIter`, `regex` `SetMatchesIter`). Rename `IterRange`, `IterRangeInclusive`, and `IterRangeFrom` to `RangeIter`, `RangeInclusiveIter`, and `RangeInclusiveIter` to match this. Tracking issue: #125687 (`new_range_api`)
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 6, 2025
Rollup of 11 pull requests Successful merges: - rust-lang/rust#148662 (alloc: Document panics when allocations will exceed max) - rust-lang/rust#148811 (core docs: rewrite `panic::Location::caller` with visual line/column numbers) - rust-lang/rust#149101 (Improve mutable-binding suggestion to include name) - rust-lang/rust#149477 (float::maximum/minimum: make docs more streamlined) - rust-lang/rust#149547 (library: Rename `IterRange*` to `Range*Iter`) - rust-lang/rust#149548 (Generate delegation error body when delegation is not resolved) - rust-lang/rust#149630 (Check identifiers defined in macros when suggesting identifiers hidden by hygiene) - rust-lang/rust#149647 (Add regression test for 141845) - rust-lang/rust#149661 (Fix for LLVM22 making lowering decisions dependent on RuntimeLibraryInfo.) - rust-lang/rust#149666 (Add perma-unstable `--print=backend-has-zstd` for use by compiletest) - rust-lang/rust#149671 (interpret: test SNaN handling of float min/max and update comments) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a weak convention in the ecosystem that
IterFoosis an iterator yielding items of typeFoo(e.g.bitflagsIterNames,hashbrownIterBuckets), whileFooIteris an iterator overFoofrom an.iter()or.into_iter()method (e.g.memchrOneIter,regexSetMatchesIter). RenameIterRange,IterRangeInclusive, andIterRangeFromtoRangeIter,RangeInclusiveIter, andRangeInclusiveIterto match this.Tracking issue: #125687 (
new_range_api)