Skip to content

Conversation

@Zalathar
Copy link
Member

@Zalathar Zalathar commented Dec 8, 2025

Using a defaulted CodegenBackend method that querying for zstd support should automatically print a safe value of false on any backend that doesn't specifically indicate the presence or absence of zstd.

This should fix the compiletest failures reported in #149666 (comment), which can occur when LLVM is not the default codegen backend.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 8, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Zalathar
Copy link
Member Author

Zalathar commented Dec 8, 2025

cc @bjorn3

@bjorn3
Copy link
Member

bjorn3 commented Dec 8, 2025

Would you mind removing https://github.com/rust-lang/rust/pull/149776/files#diff-b5a09d09fd21f3236a6ae904132f826f38c29be9347281fc97de6792fe081df4R163-R172 in this PR once the subtree sync lands?

@rustbot
Copy link
Collaborator

rustbot commented Dec 9, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Using a defaulted `CodegenBackend` method that querying for zstd support should
automatically print a safe value of `false` on any backend that doesn't
specifically indicate the presence or absence of zstd.
@rustbot
Copy link
Collaborator

rustbot commented Dec 9, 2025

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

compiletest directives have been modified. Please add or update docs for the
new or modified directive in src/doc/rustc-dev-guide/.

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 9, 2025
@Zalathar
Copy link
Member Author

Zalathar commented Dec 9, 2025

Removed the now-dead implementation of PrintKind::BackendHasZstd from cg_clif, and added a FIXME comment to llvm_has_zstd in compiletest (diff).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants