Skip to content

Updated ssh fingerprint hash-type default to sah256 for Nitrogen and remove md5 warnings#40899

Merged
cachedout merged 3 commits intosaltstack:nitrogenfrom
rallytime:remove-md5-warning
May 3, 2017
Merged

Updated ssh fingerprint hash-type default to sah256 for Nitrogen and remove md5 warnings#40899
cachedout merged 3 commits intosaltstack:nitrogenfrom
rallytime:remove-md5-warning

Conversation

@rallytime
Copy link
Contributor

@rallytime rallytime commented Apr 26, 2017

Refs #40543

@ghost
Copy link

ghost commented Apr 26, 2017

@rallytime, thanks for your PR! By analyzing the history of the files in this pull request, we identified @imankulov, @terminalmage and @garethgreenaway to be potential reviewers.

cachedout
cachedout suggested changes Apr 27, 2017
View reviewed changes
salt/modules/ssh.py
log.warning('Public Key hashing currently defaults to "md5". This will '
'change to "sha256" in the Nitrogen release.')
hash_type = 'md5'
hash_type = 'sha256'
Copy link
Contributor

@cachedout cachedout Apr 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is breaking the tests.

@rallytime
Copy link
Contributor Author

rallytime commented May 1, 2017

Go Go Jenkins!

@rallytime rallytime changed the title Remove warnings about md5 hash-type for Nitrogen Updated ssh fingerprint hash-type default to sah256 for Nitrogen and remove md5 warnings May 2, 2017
@rallytime
Copy link
Contributor Author

rallytime commented May 2, 2017

@cachedout These failing tests should be fixed now. :)

@cachedout cachedout merged commit 3626258 into saltstack:nitrogen May 3, 2017
@rallytime rallytime deleted the remove-md5-warning branch May 3, 2017 16:56
@rallytime
Copy link
Contributor Author

rallytime commented May 3, 2017 •
edited
Loading

This is causing the tests to hang on the nitrogen branch right here:

17:12:57 Starting External Pillar Tests
17:12:57 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
17:12:57 
17:12:57 Running tests...
17:12:57 ----------------------------------------------------------------------
17:12:57   test_includes_disabled (integration.pillar.test_git_pillar.TestGitPythonAuthenticatedHTTP)
17:12:57 [CPU:100.0%|MEM:73.7%]  ... SKIP (0.001s)
17:12:57   test_includes_enabled (integration.pillar.test_git_pillar.TestGitPythonAuthenticatedHTTP)
17:12:57 [CPU:0.0%|MEM:73.7%]  ... SKIP (0.001s)
17:12:57   test_multiple_sources_dev_master_merge_lists (integration.pillar.test_git_pillar.TestGitPythonAuthenticatedHTTP)
17:12:57 [CPU:0.0%|MEM:73.7%]  ... SKIP (0.001s)
17:12:57   test_multiple_sources_dev_master_no_merge_lists (integration.pillar.test_git_pillar.TestGitPythonAuthenticatedHTTP)
17:12:57 [CPU:0.0%|MEM:73.7%]  ... SKIP (0.001s)
17:12:57   test_multiple_sources_master_dev_merge_lists (integration.pillar.test_git_pillar.TestGitPythonAuthenticatedHTTP)
17:12:57 [CPU:0.0%|MEM:73.7%]  ... SKIP (0.001s)
17:12:57   test_multiple_sources_master_dev_no_merge_lists (integration.pillar.test_git_pillar.TestGitPythonAuthenticatedHTTP)
17:12:57 [CPU:0.0%|MEM:73.7%]  ... SKIP (0.001s)
17:12:57   test_multiple_sources_with_pillarenv (integration.pillar.test_git_pillar.TestGitPythonAuthenticatedHTTP)
17:12:57 [CPU:0.0%|MEM:73.7%]  ... SKIP (0.001s)
17:12:57   test_single_source (integration.pillar.test_git_pillar.TestGitPythonAuthenticatedHTTP)
17:12:57 [CPU:0.0%|MEM:73.7%]  ... SKIP (0.001s)
17:12:57   test_includes_disabled (integration.pillar.test_git_pillar.TestGitPythonHTTP)
17:12:57 [CPU:100.0%|MEM:73.7%]  ... SKIP (0.001s)
17:12:57   test_includes_enabled (integration.pillar.test_git_pillar.TestGitPythonHTTP)
17:12:57 [CPU:0.0%|MEM:73.7%]  ... SKIP (0.001s)
17:12:57   test_multiple_sources_dev_master_merge_lists (integration.pillar.test_git_pillar.TestGitPythonHTTP)
17:12:57 [CPU:0.0%|MEM:73.7%]  ... SKIP (0.001s)
17:12:57   test_multiple_sources_dev_master_no_merge_lists (integration.pillar.test_git_pillar.TestGitPythonHTTP)
17:12:57 [CPU:0.0%|MEM:73.7%]  ... SKIP (0.001s)
17:12:57   test_multiple_sources_master_dev_merge_lists (integration.pillar.test_git_pillar.TestGitPythonHTTP)
17:12:57 [CPU:0.0%|MEM:73.7%]  ... SKIP (0.001s)
17:12:57   test_multiple_sources_master_dev_no_merge_lists (integration.pillar.test_git_pillar.TestGitPythonHTTP)
17:12:57 [CPU:0.0%|MEM:73.7%]  ... SKIP (0.001s)
17:12:57   test_multiple_sources_with_pillarenv (integration.pillar.test_git_pillar.TestGitPythonHTTP)
17:12:57 [CPU:100.0%|MEM:73.7%]  ... SKIP (0.001s)
17:12:57   test_single_source (integration.pillar.test_git_pillar.TestGitPythonHTTP)
17:12:57 [CPU:0.0%|MEM:73.7%]  ... SKIP (0.001s)
17:12:57   test_includes_disabled (integration.pillar.test_git_pillar.TestGitPythonSSH)
17:12:59 [CPU:100.0%|MEM:73.7%]  ... ERROR (2.482s)
17:12:59   test_includes_enabled (integration.pillar.test_git_pillar.TestGitPythonSSH)
17:13:04 The authenticity of host '[127.0.0.1]:39093 ([127.0.0.1]:39093)' can't be established.

So I am reverting this for now. I'll have to resubmit once those tests are fixed.

@rallytime rallytime mentioned this pull request May 3, 2017
Merged
@rallytime rallytime mentioned this pull request May 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cachedout cachedout cachedout approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rallytime @cachedout

Comments