Insert Splicer in ReifyQuote

Author: nicolasstucki

compiler/src/dotty/tools/dotc/interpreter/Interpreter.scala

@@ -5,6 +5,7 @@ import dotty.tools.dotc.ast.tpd
 import dotty.tools.dotc.ast.Trees._
 import dotty.tools.dotc.core.Constants._
 import dotty.tools.dotc.core.Contexts._
+import dotty.tools.dotc.core.Flags._
 import dotty.tools.dotc.core.Decorators._
 import dotty.tools.dotc.core.Symbols._
 
@@ -79,6 +80,12 @@ class Interpreter(implicit ctx: Context) {
           val method = clazz.getMethod(tree.name.toString)
           method.invoke(null)
 
+        case tree: RefTree if tree.symbol.is(Module) =>
+          ??? // TODO
+
+        case Inlined(_, bindings, expansion) =>
+          // TODO evaluate bindings and add environment
+          interpretTreeImpl(expansion)
         case _ =>
           val msg =
             if (tree.tpe.derivesFrom(defn.QuotedExprClass)) "Quote needs to be explicit or a call to a static method"

compiler/src/dotty/tools/dotc/transform/ReifyQuotes.scala

@@ -328,7 +328,8 @@ class ReifyQuotes extends MacroTransform {
           case Inlined(call, bindings, expansion @ Select(body, name)) if expansion.symbol.isSplice =>
             // To maintain phase consistency, convert inlined expressions of the form
             // `{ bindings; ~expansion }` to `~{ bindings; expansion }`
-            cpy.Select(expansion)(cpy.Inlined(tree)(call, bindings, body), name)
+            if (level == 0) Splicer.splice(cpy.Inlined(tree)(call, bindings, body))
+            else cpy.Select(expansion)(cpy.Inlined(tree)(call, bindings, body), name)
           case _: Import =>
             tree
           case tree: DefDef if tree.symbol.is(Macro) && level == 0 =>

compiler/src/dotty/tools/dotc/transform/Splicer.scala

@@ -22,7 +22,7 @@ object Splicer {
     case TypeApply(quote, quoted :: Nil) if quote.symbol == defn.typeQuoteMethod => quoted
     case tree: RefTree => reflectiveSplice(tree)
     case tree: Apply => reflectiveSplice(tree)
-    case Inlined(_, _, expansion) => splice(expansion)
+    case tree: Inlined => reflectiveSplice(tree)
   }
 
   /** Splice the Tree for a Quoted expression which is constructed via a reflective call to the given method */

tests/run/quote-and-splice/Test_2.scala

@@ -2,12 +2,7 @@ object Test {
   import Macros._
 
   def main(args: Array[String]): Unit = {
-    try {
-      println(macro1)
-    } catch {
-      case _: Error => // FIXME remove try/catch
-      println(3)
-    }
+    println(macro1)
   }
 
 }