Simplify generation of ParamInfo.withAnnotations

Author: nicolasstucki

compiler/src/dotty/tools/dotc/ast/MainProxies.scala

@@ -247,15 +247,12 @@ object MainProxies {
 
         val constructorArgs = List(param, paramTypeStr, hasDefault, isRepeated, paramDoc)
           .map(value => Literal(Constant(value)))
-
-        var paramInfos =
+        val paramInfos =
           New(TypeTree(defn.MainAnnotationParameterInfo.typeRef), List(constructorArgs))
-
         val paramAnnots = paramAnnotations(idx)
         if paramAnnots.nonEmpty then
-          paramInfos = paramInfos.withProperty(defn.MainAnnotationParameterInfo_withAnnotations, paramAnnots.map(instantiateAnnotation).toList)
-
-        paramInfos
+          paramInfos.withProperty(defn.MainAnnotationParameterInfo_withAnnotations, paramAnnots.map(instantiateAnnotation).toList)
+        else paramInfos
     end parameterInfos
 
     /**

library/src/scala/annotation/MainAnnotation.scala

@@ -24,6 +24,7 @@ trait MainAnnotation extends StaticAnnotation:
 
   /** A new command with arguments from `args` */
   def command(args: Array[String], commandName: String, documentation: String, parameterInfos: ParameterInfo*): Command[Parser, Result]
+
 end MainAnnotation
 
 @experimental
@@ -37,6 +38,7 @@ object MainAnnotation:
     paramDocumentation: String,
     paramAnnotations: Seq[ParameterAnnotation],
   ) {
+
     /** ParameterInfo with a name, the type of the parameter and if it has a default */
     def this(name: String, typeName: String, hasDefault: Boolean, isVarargs: Boolean, documentation: String) =
       this(name, typeName, hasDefault, isVarargs, documentation, Seq.empty)
@@ -83,4 +85,5 @@ object MainAnnotation:
 
   /** Marker trait for annotations that will be included in the ParameterInfo annotations. */
   trait ParameterAnnotation extends StaticAnnotation
+
 end MainAnnotation