Fix assert when xCheckMacro conditions

Author: nicolasstucki

compiler/src/scala/quoted/runtime/impl/QuotesImpl.scala

@@ -266,8 +266,8 @@ class QuotesImpl private (using val ctx: Context) extends Quotes, QuoteUnpickler
 
     object DefDef extends DefDefModule:
       def apply(symbol: Symbol, rhsFn: List[List[Tree]] => Option[Term]): DefDef =
-        assert(xCheckMacro && symbol.isTerm, s"expected a term symbol but received $symbol")
-        assert(xCheckMacro && symbol.flags.is(Flags.Method), "expected a symbol with `Method` flag set")
+        assert(!xCheckMacro || symbol.isTerm, s"expected a term symbol but received $symbol")
+        assert(!xCheckMacro || symbol.flags.is(Flags.Method), "expected a symbol with `Method` flag set")
         withDefaultPos(tpd.DefDef(symbol.asTerm, prefss =>
           xCheckedMacroOwners(xCheckMacroValidExpr(rhsFn(prefss)), symbol).getOrElse(tpd.EmptyTree)
         ))
@@ -298,7 +298,7 @@ class QuotesImpl private (using val ctx: Context) extends Quotes, QuoteUnpickler
 
     object ValDef extends ValDefModule:
       def apply(symbol: Symbol, rhs: Option[Term]): ValDef =
-        assert(xCheckMacro && !symbol.flags.is(Flags.Method), "expected a symbol without `Method` flag set")
+        assert(!xCheckMacro || !symbol.flags.is(Flags.Method), "expected a symbol without `Method` flag set")
         tpd.ValDef(symbol.asTerm, xCheckedMacroOwners(xCheckMacroValidExpr(rhs), symbol).getOrElse(tpd.EmptyTree))
       def copy(original: Tree)(name: String, tpt: TypeTree, rhs: Option[Term]): ValDef =
         tpd.cpy.ValDef(original)(name.toTermName, tpt, xCheckedMacroOwners(xCheckMacroValidExpr(rhs), original.symbol).getOrElse(tpd.EmptyTree))
@@ -1475,7 +1475,7 @@ class QuotesImpl private (using val ctx: Context) extends Quotes, QuoteUnpickler
 
     object Bind extends BindModule:
       def apply(sym: Symbol, pattern: Tree): Bind =
-        assert(xCheckMacro && sym.flags.is(Flags.Case), "expected a symbol with `Case` flag set")
+        assert(!xCheckMacro || sym.flags.is(Flags.Case), "expected a symbol with `Case` flag set")
         tpd.Bind(sym, pattern)
       def copy(original: Tree)(name: String, pattern: Tree): Bind =
         withDefaultPos(tpd.cpy.Bind(original)(name.toTermName, pattern))
@@ -2504,7 +2504,7 @@ class QuotesImpl private (using val ctx: Context) extends Quotes, QuoteUnpickler
         // We introduce this check under this flag to not break published macros that may have accidentally used a wrong flag but happen to work.
         // Once macro implementation had a compiler version or two too find their bugs and patch them we can enforce it on every use site.
         assert(
-          xCheckMacro && flags <= valid,
+          !xCheckMacro || flags <= valid,
           s"Received invalid flags. Expected flags ${flags.show} to only contain a subset of ${valid.show}."
         )