WIP try to not read empty comments

nicolasstucki · nicolasstucki · commit b55f95d59811 · 2023-11-27T10:20:27.000+01:00
diff --git a/compiler/src/dotty/tools/dotc/core/tasty/CommentUnpickler.scala b/compiler/src/dotty/tools/dotc/core/tasty/CommentUnpickler.scala
@@ -21,8 +21,9 @@ class CommentUnpickler(reader: TastyReader) {
       val addr = readAddr()
       val length = readNat()
       val rawComment = readUtf8()
-      val position = new Span(readLongInt())
-      comments(addr) = Comment(position, rawComment)
+      if rawComment.nonEmpty then
+        val position = new Span(readLongInt())
+        comments(addr) = Comment(position, rawComment)
     }
     comments
   }

Original file line number	Diff line number	Diff line change
`@@ -21,8 +21,9 @@ class CommentUnpickler(reader: TastyReader) {`
`21`	`21`	`val addr = readAddr()`
`22`	`22`	`val length = readNat()`
`23`	`23`	`val rawComment = readUtf8()`
`24`		`- val position = new Span(readLongInt())`
`25`		`- comments(addr) = Comment(position, rawComment)`
	`24`	`+ if rawComment.nonEmpty then`
	`25`	`+ val position = new Span(readLongInt())`
	`26`	`+ comments(addr) = Comment(position, rawComment)`
`26`	`27`	`}`
`27`	`28`	`comments`
`28`	`29`	`}`