Skip to content

Conversation

@Monitob
Copy link
Contributor

@Monitob Monitob commented Oct 14, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #2547

Release note for CHANGELOG:


@Monitob Monitob added enhancement rdb Managed MySQL and PostgreSQL issues, bugs and feature requests labels Oct 14, 2022
@Monitob Monitob self-assigned this Oct 14, 2022
@Monitob Monitob force-pushed the feat-rdb-engine-settings branch from 460d91d to 2073c63 Compare October 14, 2022 12:57
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2022

Codecov Report

Merging #2548 (05450a3) into master (121b725) will increase coverage by 0.07%.
The diff coverage is 89.65%.

@@            Coverage Diff             @@
##           master    #2548      +/-   ##
==========================================
+ Coverage   76.60%   76.68%   +0.07%     
==========================================
  Files         131      133       +2     
  Lines       23839    23925      +86     
==========================================
+ Hits        18263    18348      +85     
+ Misses       4979     4978       -1     
- Partials      597      599       +2     
Impacted Files Coverage Δ
internal/namespaces/lb/v1/custom_lb.go 91.95% <85.00%> (-2.08%) ⬇️
internal/namespaces/lb/v1/custom_backend.go 85.71% <85.71%> (ø)
...ternal/namespaces/rdb/v1/custom_engine_settings.go 91.42% <91.42%> (ø)
internal/namespaces/lb/v1/custom.go 100.00% <100.00%> (ø)
internal/namespaces/lb/v1/custom_certificate.go 75.36% <100.00%> (+3.23%) ⬆️
internal/namespaces/rdb/v1/custom.go 100.00% <100.00%> (ø)
internal/namespaces/lb/v1/lb_cli.go 87.34% <0.00%> (+0.39%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@remyleone
Copy link
Member

Not working with:

$ go run ./cmd/scw rdb engine settings name=Postgresql version=13
NAME  DEFAULT VALUE  HOT CONFIGURABLE  DESCRIPTION  PROPERTY TYPE  UNIT  STRING CONSTRAINT  INT MIN  INT MAX  FLOAT MIN  FLOAT MAX

@remyleone remyleone linked an issue Oct 17, 2022 that may be closed by this pull request
@Monitob Monitob force-pushed the feat-rdb-engine-settings branch from 1587edf to 584ad3c Compare November 15, 2022 14:48
@remyleone remyleone merged commit bb0012c into scaleway:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement rdb Managed MySQL and PostgreSQL issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RDB: list init_settings and settings

6 participants