Skip to content

Conversation

@Codelax
Copy link
Member

@Codelax Codelax commented Dec 27, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@Codelax Codelax added the core label Dec 27, 2022
@Codelax Codelax self-assigned this Dec 27, 2022
@Codelax Codelax changed the title perf(core): allocate maps with number of commands and use unordered list perf(core): cobra builder allocate with nb of commands and use unordered list Dec 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2022

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.52%. Comparing base (efb08dd) to head (280eabf).
Report is 1377 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/cobra_usage_builder.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2702      +/-   ##
==========================================
- Coverage   75.55%   75.52%   -0.04%     
==========================================
  Files         134      134              
  Lines       25031    25042      +11     
==========================================
  Hits        18913    18913              
- Misses       5477     5487      +10     
- Partials      641      642       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@remyleone remyleone merged commit 9d30336 into scaleway:master Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants