Skip to content

fix(iam): use expired and not expirable to filter expired API keys #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Monitob merged 2 commits into from
Feb 17, 2023
Merged

fix(iam): use expired and not expirable to filter expired API keys #2782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff18f7d
feat: update generated APIs
scaleway-bot Feb 16, 2023
b780195
Merge branch 'master' into v1.3221.0
Monitob Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/scw/testdata/test-all-usage-iam-api-key-list-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ USAGE:
ARGS:
[order-by=created_at_asc] Criteria for sorting results (created_at_asc | created_at_desc | updated_at_asc | updated_at_desc | expires_at_asc | expires_at_desc | access_key_asc | access_key_desc)
[editable] Filter out editable API keys or not
[expirable] Filter out expirable API keys or not
[expired] Filter out expired API keys or not
[access-key] Filter out by access key
[description] Filter out by description
[bearer-id] Filter out by bearer ID
Expand Down
2 changes: 1 addition & 1 deletion docs/commands/iam.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ scw iam api-key list [arg=value ...]
| ~~application-id~~ | Deprecated | ID of an application bearer |
| ~~user-id~~ | Deprecated | ID of a user bearer |
| editable | | Filter out editable API keys or not |
| expirable | | Filter out expirable API keys or not |
| expired | | Filter out expired API keys or not |
| access-key | | Filter out by access key |
| description | | Filter out by description |
| bearer-id | | Filter out by bearer ID |
Expand Down
4 changes: 2 additions & 2 deletions internal/namespaces/iam/v1alpha1/iam_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1562,8 +1562,8 @@ func iamAPIKeyList() *core.Command {
Positional: false,
},
{
Name: "expirable",
Short: `Filter out expirable API keys or not`,
Name: "expired",
Short: `Filter out expired API keys or not`,
Required: false,
Deprecated: false,
Positional: false,
Expand Down