Skip to content

feat(secret_manager): add name filter to ListSecrets #2817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Codelax merged 1 commit into from
Feb 28, 2023
Merged

feat(secret_manager): add name filter to ListSecrets #2817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/scw/testdata/test-all-usage-secret-secret-list-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ USAGE:

ARGS:
[project-id] ID of a project to filter on (optional)
[name] Secret name to filter on (optional)
[tags.{index}] List of tags to filter on (optional)
[order-by] (name_asc | name_desc | created_at_asc | created_at_desc | updated_at_asc | updated_at_desc)
[organization-id] ID of an organization to filter on (optional)
Expand Down
1 change: 1 addition & 0 deletions docs/commands/secret.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ scw secret secret list [arg=value ...]
| Name | | Description |
|------|---|-------------|
| project-id | | ID of a project to filter on (optional) |
| name | | Secret name to filter on (optional) |
| tags.{index} | | List of tags to filter on (optional) |
| order-by | One of: `name_asc`, `name_desc`, `created_at_asc`, `created_at_desc`, `updated_at_asc`, `updated_at_desc` | |
| organization-id | | ID of an organization to filter on (optional) |
Expand Down
7 changes: 7 additions & 0 deletions internal/namespaces/secret/v1alpha1/secret_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,13 @@ func secretSecretList() *core.Command {
Deprecated: false,
Positional: false,
},
{
Name: "name",
Short: `Secret name to filter on (optional)`,
Required: false,
Deprecated: false,
Positional: false,
},
{
Name: "tags.{index}",
Short: `List of tags to filter on (optional)`,
Expand Down