Skip to content

Conversation

@Codelax
Copy link
Member

@Codelax Codelax commented Mar 6, 2023

Shell would spam request on each character change or cursor move

Example:

  • instance server list name=| => request
  • instance server list name=c| => request
  • instance server list name=|c => request

Now request get cached
Example:

  • instance server list name=| => request
  • instance server list name=c|
  • instance server list name=|c

@codecov-commenter
Copy link

Codecov Report

Merging #2846 (e1ca24c) into master (fd66ebe) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2846      +/-   ##
==========================================
- Coverage   74.80%   74.71%   -0.10%     
==========================================
  Files         142      142              
  Lines       28623    28658      +35     
==========================================
  Hits        21411    21411              
- Misses       6471     6506      +35     
  Partials      741      741              
Impacted Files Coverage Δ
internal/core/shell.go 8.67% <0.00%> (-1.66%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@remyleone remyleone added this pull request to the merge queue Mar 6, 2023
Merged via the queue into scaleway:master with commit bfec5e1 Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants