-
Notifications
You must be signed in to change notification settings - Fork 156
feat(billing): add billing command #2931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
remyleone
merged 18 commits into
scaleway:master
from
Monitob:feat-enable-billing-commands
Apr 27, 2023
Merged
feat(billing): add billing command #2931
remyleone
merged 18 commits into
scaleway:master
from
Monitob:feat-enable-billing-commands
Apr 27, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aa3fa2e to
67ddfe4
Compare
kindermoumoute
requested changes
Mar 24, 2023
internal/namespaces/billing/v2alpha1/custom_billing_download.go
Outdated
Show resolved
Hide resolved
internal/namespaces/billing/v2alpha1/custom_billing_download.go
Outdated
Show resolved
Hide resolved
internal/namespaces/billing/v2alpha1/custom_billing_download.go
Outdated
Show resolved
Hide resolved
2535173 to
e44f6b0
Compare
Codecov Report
@@ Coverage Diff @@
## master #2931 +/- ##
=======================================
Coverage 75.41% 75.41%
=======================================
Files 163 163
Lines 34797 34797
=======================================
Hits 26241 26241
Misses 7655 7655
Partials 901 901 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1927a63 to
b210a83
Compare
kindermoumoute
requested changes
Apr 4, 2023
cmd/scw/testdata/test-all-usage-billing-invoice-download-usage.golden
Outdated
Show resolved
Hide resolved
internal/namespaces/billing/v2alpha1/custom_billing_download.go
Outdated
Show resolved
Hide resolved
internal/namespaces/billing/v2alpha1/custom_billing_download.go
Outdated
Show resolved
Hide resolved
2198785 to
0d71399
Compare
117bcc5 to
2aca2bf
Compare
Co-authored-by: Olivier Cano <kindermoumoute@users.noreply.github.com>
Co-authored-by: Olivier Cano <kindermoumoute@users.noreply.github.com>
2aca2bf to
1c005cc
Compare
kindermoumoute
requested changes
Apr 27, 2023
internal/namespaces/billing/v2alpha1/custom_billing_download.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Olivier Cano <kindermoumoute@users.noreply.github.com>
kindermoumoute
approved these changes
Apr 27, 2023
Contributor
kindermoumoute
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Release note for CHANGELOG: