Skip to content

fix(instance): split security group marshalers #2939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Codelax merged 5 commits into from
Mar 24, 2023
Merged

fix(instance): split security group marshalers #2939

Codelax merged 5 commits into from
Mar 24, 2023

Conversation

@Codelax
Copy link
Member

@Codelax Codelax commented Mar 24, 2023

No description provided.

@Codelax Codelax added the instance Instance issues, bugs and feature requests label Mar 24, 2023
@Codelax Codelax self-assigned this Mar 24, 2023
@Codelax Codelax marked this pull request as draft March 24, 2023 13:59
@Codelax Codelax changed the title tests(instance): split security group marshalers fix(instance): split security group marshalers Mar 24, 2023
@Codelax Codelax marked this pull request as ready for review March 24, 2023 14:09
quantumsheep
quantumsheep requested changes Mar 24, 2023
View reviewed changes
Codelax and others added 3 commits March 24, 2023 15:20
@Codelax @quantumsheep
Update internal/namespaces/instance/v1/custom_security_group.go
9821c6a 
Co-authored-by: Nathanael Demacon <nathanael.dmc@outlook.fr>
@Codelax @quantumsheep
Update internal/namespaces/instance/v1/custom_security_group_test.go
93bc311 
Co-authored-by: Nathanael Demacon <nathanael.dmc@outlook.fr>
@Codelax
fix linter
53d9475
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2023 •
edited
Loading

Codecov Report

Merging #2939 (53d9475) into master (715871c) will increase coverage by 0.29%.
The diff coverage is 89.18%.

@@            Coverage Diff             @@
##           master    #2939      +/-   ##
==========================================
+ Coverage   74.85%   75.14%   +0.29%     
==========================================
  Files         149      149              
  Lines       32031    32041      +10     
==========================================
+ Hits        23977    24078     +101     
+ Misses       7215     7116      -99     
- Partials      839      847       +8
Impacted Files Coverage Δ
...al/namespaces/instance/v1/custom_security_group.go 59.24% <88.88%> (+26.00%) ⬆️
internal/namespaces/instance/v1/custom.go 98.06% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Codelax Codelax added this pull request to the merge queue Mar 24, 2023
Merged via the queue into scaleway:master with commit cd1366b Mar 24, 2023
@Codelax Codelax deleted the fix/security-group-rules-marshal branch March 24, 2023 14:41
@Codelax Codelax mentioned this pull request Mar 24, 2023
Merged
Monitob pushed a commit to Monitob/scaleway-cli that referenced this pull request Mar 28, 2023
@Codelax @quantumsheep @Monitob
fix(instance): split security group marshalers (scaleway#2939)
6c8b660 
Co-authored-by: Nathanael Demacon <nathanael.dmc@outlook.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@remyleone remyleone remyleone approved these changes

@quantumsheep quantumsheep quantumsheep approved these changes

Assignees

@Codelax Codelax

Labels

instance Instance issues, bugs and feature requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Codelax @codecov-commenter @remyleone @quantumsheep