Skip to content

Conversation

@Codelax
Copy link
Member

@Codelax Codelax commented Apr 27, 2023

Closes #2936

@Codelax Codelax added enhancement container Container issues, bugs and feature requests labels Apr 27, 2023
@Codelax Codelax self-assigned this Apr 27, 2023
@Codelax Codelax marked this pull request as draft May 2, 2023 09:41
@codecov-commenter
Copy link

Codecov Report

Merging #3098 (cb1087a) into master (3252886) will decrease coverage by 0.01%.
The diff coverage is 38.88%.

@@            Coverage Diff             @@
##           master    #3098      +/-   ##
==========================================
- Coverage   75.79%   75.78%   -0.01%     
==========================================
  Files         169      169              
  Lines       36631    36686      +55     
==========================================
+ Hits        27765    27804      +39     
- Misses       7903     7919      +16     
  Partials      963      963              
Impacted Files Coverage Δ
...l/namespaces/container/v1beta1/custom_namespace.go 65.78% <26.66%> (+8.21%) ⬆️
...l/namespaces/container/v1beta1/custom_container.go 45.00% <38.88%> (+30.71%) ⬆️
internal/namespaces/container/v1beta1/custom.go 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@Codelax Codelax marked this pull request as ready for review May 2, 2023 11:23
@remyleone remyleone added this pull request to the merge queue May 2, 2023
Merged via the queue into scaleway:master with commit ff568a1 May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

container Container issues, bugs and feature requests enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add container waiters

3 participants