From 529692884a32762eec2aada7739709ab81d1e24e Mon Sep 17 00:00:00 2001 From: HAOYUatHZ Date: Thu, 24 Oct 2024 10:32:23 +0800 Subject: [PATCH 1/3] feat(coordinator): add version check for sdk provers --- common/version/prover_version.go | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/common/version/prover_version.go b/common/version/prover_version.go index 6b49164364..2b7a52f3b3 100644 --- a/common/version/prover_version.go +++ b/common/version/prover_version.go @@ -9,6 +9,10 @@ import ( // CheckScrollProverVersion check the "scroll-prover" version, if it's different from the local one, return false func CheckScrollProverVersion(proverVersion string) bool { + if strings.HasPrefix(proverVersion, "sdk") { + return CheckProverSDKVersion(proverVersion) + } + // note the version is in fact in the format of "tag-commit-scroll_prover-halo2", // so split-by-'-' length should be 4 remote := strings.Split(proverVersion, "-") @@ -23,8 +27,18 @@ func CheckScrollProverVersion(proverVersion string) bool { return remote[2] == local[2] } +// CheckProverSDKVersion check prover sdk version, it simply returns true for now, +// and more checks will be added as we evolve. +func CheckProverSDKVersion(proverVersion string) bool { + return true +} + // CheckScrollRepoVersion checks if the proverVersion is at least the minimum required version. func CheckScrollRepoVersion(proverVersion, minVersion string) bool { + if strings.HasPrefix(proverVersion, "sdk") { + return CheckProverSDKWithMinVersion(proverVersion, minVersion) + } + c, err := semver.NewConstraint(">= " + minVersion + "-0") if err != nil { log.Error("failed to initialize constraint", "minVersion", minVersion, "error", err) @@ -39,3 +53,9 @@ func CheckScrollRepoVersion(proverVersion, minVersion string) bool { return c.Check(v) } + +// CheckProverSDKWithMinVersion check prover sdk version is at least the minimum required version, it simply returns true for now, +// and more checks will be added as we evolve. +func CheckProverSDKWithMinVersion(proverVersion string, minVersion string) bool { + return true +} From 71b3fc8f5f36df93f42be7d3b3618e72953ae632 Mon Sep 17 00:00:00 2001 From: 0xmountaintop <0xmountaintop@users.noreply.github.com> Date: Thu, 24 Oct 2024 02:33:27 +0000 Subject: [PATCH 2/3] =?UTF-8?q?chore:=20auto=20version=20bump=E2=80=89[bot?= =?UTF-8?q?]?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- common/version/version.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/version/version.go b/common/version/version.go index 696291edd0..9e5f7a7711 100644 --- a/common/version/version.go +++ b/common/version/version.go @@ -5,7 +5,7 @@ import ( "runtime/debug" ) -var tag = "v4.4.70" +var tag = "v4.4.71" var commit = func() string { if info, ok := debug.ReadBuildInfo(); ok { From 4b290c8408db9d09a18561030c541c6fa151757e Mon Sep 17 00:00:00 2001 From: 0xmountaintop <0xmountaintop@users.noreply.github.com> Date: Wed, 30 Oct 2024 00:47:54 +0000 Subject: [PATCH 3/3] =?UTF-8?q?chore:=20auto=20version=20bump=E2=80=89[bot?= =?UTF-8?q?]?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- common/version/version.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/version/version.go b/common/version/version.go index 9e5f7a7711..83bff50dea 100644 --- a/common/version/version.go +++ b/common/version/version.go @@ -5,7 +5,7 @@ import ( "runtime/debug" ) -var tag = "v4.4.71" +var tag = "v4.4.72" var commit = func() string { if info, ok := debug.ReadBuildInfo(); ok {