Skip to content

Commit 9723584

Browse files
committed
remove add/delete comment apis
1 parent 270da4e commit 9723584

File tree

2 files changed

+6
-69
lines changed

2 files changed

+6
-69
lines changed

seatable_api/exception.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,3 @@ class AuthExpiredError(ConnectionError):
44

55
def __str__(self):
66
return "The authorization has been expired"
7-
8-
class UserAuthMissingError(Exception):
9-
10-
def __str__(self):
11-
return 'User authorization is missing'

seatable_api/main.py

Lines changed: 6 additions & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,8 @@ def __init__(self, token, server_url):
6464
self.dtable_server_url = None
6565
self.dtable_db_url = None
6666
self.jwt_token = None
67-
self.user_jwt_token = None
6867
self.jwt_exp = None
6968
self.headers = None
70-
self.user_headers = None
7169
self.workspace_id = None
7270
self.dtable_uuid = None
7371
self.dtable_name = None
@@ -120,24 +118,6 @@ def auth(self, with_socket_io=False):
120118
self.socketIO = SocketIO(base)
121119
self.socketIO._connect()
122120

123-
def auth_as_user(self, login, password):
124-
"""Auth to SeaTable as user
125-
"""
126-
self.jwt_exp = datetime.now() + timedelta(days=3)
127-
url = self.server_url + '/api/v2.1/dtable/app-user-access-token/'
128-
headers = parse_headers(self.token)
129-
data = {'login': login, 'password': password}
130-
response = requests.post(url, json=data, headers=headers, timeout=self.timeout)
131-
data = parse_response(response)
132-
133-
self.dtable_server_url = parse_server_url(data.get('dtable_server'))
134-
self.dtable_db_url = parse_server_url(data.get('dtable_db', ''))
135-
self.user_jwt_token = data.get('access_token')
136-
self.user_headers = parse_headers(self.user_jwt_token)
137-
self.workspace_id = data.get('workspace_id')
138-
self.dtable_uuid = data.get('dtable_uuid')
139-
self.dtable_name = data.get('dtable_name')
140-
141121
def _metadata_server_url(self):
142122
return self.dtable_server_url + '/api/v1/dtables/' + self.dtable_uuid + '/metadata/'
143123

@@ -221,13 +201,6 @@ def _get_account_detail(self, account_name):
221201
data = parse_response(response)
222202
return data.get('account')
223203

224-
def _add_comment_url(self):
225-
url = '%(server_url)s/api/v1/dtables/%(dtable_uuid)s/comments/' % {
226-
'server_url': self.dtable_server_url,
227-
'dtable_uuid': self.dtable_uuid
228-
}
229-
return url
230-
231204
def _get_comments_url(self):
232205
url = '%(server_url)s/api/v2.1/dtables/%(dtable_uuid)s/comments/' % {
233206
'server_url': self.server_url,
@@ -242,7 +215,7 @@ def _get_comments_count_url(self):
242215
}
243216
return url
244217

245-
def _update_or_delete_comment_url(self, comment_id):
218+
def _update_comment_url(self, comment_id):
246219
url = '%(server_url)s/api/v2.1/dtables/%(dtable_uuid)s/comments/%(comment_id)s/' % {
247220
'server_url': self.server_url,
248221
'dtable_uuid': self.dtable_uuid,
@@ -1009,30 +982,14 @@ def big_data_insert_rows(self, table_name, rows_data):
1009982
response = requests.post(url, json=json_data, headers=self.headers, timeout=self.timeout)
1010983
return parse_response(response)
1011984

1012-
def add_comment(self, table_id, row_id, comment):
1013-
"""
1014-
:param table_id: str
1015-
:param row_id: str
1016-
:param comment: str
1017-
:return: success response dict {'success': True}
1018-
"""
1019-
if not self.user_headers:
1020-
raise UserAuthMissingError('Please call Base.auth_as_user before call this method')
1021-
url = self._add_comment_url()
1022-
params = {'table_id': table_id, 'row_id': row_id}
1023-
json_data = {'comment': str(comment)}
1024-
response = requests.post(url, params=params, json=json_data, headers=self.user_headers, timeout=self.timeout)
1025-
return parse_response(response)
1026-
1027985
def get_comments_count(self, row_id):
1028986
"""
1029987
:param row_id: str
1030988
:return: int
1031989
"""
1032990
url = self._get_comments_count_url()
1033991
params = {'row_id': row_id}
1034-
headers = self.headers or self.user_headers or None
1035-
response = requests.get(url, params=params, headers=headers, timeout=self.timeout)
992+
response = requests.get(url, params=params, headers=self.headers, timeout=self.timeout)
1036993
return parse_response(response)['count']
1037994

1038995
def get_comments(self, row_id, page=1, per_page=25):
@@ -1048,8 +1005,7 @@ def get_comments(self, row_id, page=1, per_page=25):
10481005
'page': page,
10491006
'per_page': per_page
10501007
}
1051-
headers = self.headers or self.user_headers or None
1052-
response = requests.get(url, params=params, headers=headers, timeout=self.timeout)
1008+
response = requests.get(url, params=params, headers=self.headers, timeout=self.timeout)
10531009
return parse_response(response)
10541010

10551011
def resolve_comment(self, comment_id, resolved=True):
@@ -1058,23 +1014,10 @@ def resolve_comment(self, comment_id, resolved=True):
10581014
:param resolved: bool
10591015
:return: success response dict {'success': True}
10601016
"""
1061-
if not self.user_headers:
1062-
raise UserAuthMissingError('Please call Base.auth_as_user before call this method')
1063-
url = self._update_or_delete_comment_url(comment_id)
1017+
url = self._update_comment_url(comment_id)
10641018
options = {'resolved': 'true' if resolved else 'false'}
10651019
data = {'options': options}
1066-
response = requests.put(url, json=data, headers=self.user_headers, timeout=self.timeout)
1067-
return parse_response(response)
1068-
1069-
def delete_comment(self, comment_id):
1070-
"""
1071-
:param comment_id: str
1072-
:return: success response dict {'success': True}
1073-
"""
1074-
if not self.user_headers:
1075-
raise UserAuthMissingError('Please call Base.auth_as_user before call this method')
1076-
url = self._update_or_delete_comment_url(comment_id)
1077-
response = requests.delete(url, headers=self.user_headers, timeout=self.timeout)
1020+
response = requests.put(url, json=data, headers=self.headers, timeout=self.timeout)
10781021
return parse_response(response)
10791022

10801023
def get_comments_within_days(self, days=3):
@@ -1084,8 +1027,7 @@ def get_comments_within_days(self, days=3):
10841027
"""
10851028
url = self._get_comments_within_days_url()
10861029
params = {'days': days}
1087-
headers = self.headers or self.user_headers or None
1088-
response = requests.get(url, params=params, headers=headers, timeout=self.timeout)
1030+
response = requests.get(url, params=params, headers=self.headers, timeout=self.timeout)
10891031
return parse_response(response)['comment_list']
10901032

10911033

0 commit comments

Comments
 (0)