Skip to content

Commit 985f0c3

Browse files
Revert "Fix: Continue entire job when running on PHP 8.3"
This reverts commit 0c8cbe4.
1 parent b8b0f3e commit 985f0c3

File tree

1 file changed

+16
-30
lines changed

1 file changed

+16
-30
lines changed

.github/workflows/ci.yml

Lines changed: 16 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,6 @@ jobs:
6868
PHP_EXTENSIONS: none, curl, dom, json, libxml, mbstring, openssl, phar, soap, tokenizer, xml, xmlwriter
6969
PHP_INI_VALUES: assert.exception=1, zend.assertions=1, error_reporting=-1, log_errors_max_len=0, display_errors=On
7070

71-
continue-on-error: ${{ matrix.experimental }}
72-
7371
strategy:
7472
fail-fast: false
7573
matrix:
@@ -84,18 +82,7 @@ jobs:
8482
- "8.0"
8583
- "8.1"
8684
- "8.2"
87-
88-
experimental:
89-
- false
90-
91-
include:
92-
- os: ubuntu-latest
93-
php-version: "8.3"
94-
experimental: true
95-
96-
- os: windows-latest
97-
php-version: "8.3"
98-
experimental: true
85+
- "8.3"
9986

10087
steps:
10188
- name: Configure Git to avoid issues with line endings
@@ -116,7 +103,13 @@ jobs:
116103
- name: Install dependencies with Composer
117104
run: ./tools/composer update --no-ansi --no-interaction --no-progress
118105

119-
- name: Run tests with PHPUnit
106+
- name: Run tests with PHPUnit on stable PHP version
107+
if: matrix.php-version != '8.3'
108+
run: ./phpunit --testsuite unit
109+
110+
- name: Run tests with PHPUnit on unstable PHP version
111+
if: matrix.php-version == '8.3'
112+
continue-on-error: true
120113
run: ./phpunit --testsuite unit
121114

122115
end-to-end-tests:
@@ -131,8 +124,6 @@ jobs:
131124
PHP_EXTENSIONS: none, curl, dom, json, libxml, mbstring, openssl, phar, soap, tokenizer, xml, xmlwriter
132125
PHP_INI_VALUES: assert.exception=1, zend.assertions=1, error_reporting=-1, log_errors_max_len=0, display_errors=On
133126

134-
continue-on-error: ${{ matrix.experimental }}
135-
136127
strategy:
137128
fail-fast: false
138129
matrix:
@@ -147,18 +138,7 @@ jobs:
147138
- "8.0"
148139
- "8.1"
149140
- "8.2"
150-
151-
experimental:
152-
- false
153-
154-
include:
155-
- os: ubuntu-latest
156-
php-version: "8.3"
157-
experimental: true
158-
159-
- os: windows-latest
160-
php-version: "8.3"
161-
experimental: true
141+
- "8.3"
162142

163143
steps:
164144
- name: Configure Git to avoid issues with line endings
@@ -179,7 +159,13 @@ jobs:
179159
- name: Install dependencies with Composer
180160
run: ./tools/composer update --no-ansi --no-interaction --no-progress
181161

182-
- name: Run tests with PHPUnit
162+
- name: Run tests with PHPUnit on stable PHP version
163+
if: matrix.php-version != '8.3'
164+
run: ./phpunit --testsuite end-to-end
165+
166+
- name: Run tests with PHPUnit on unstable PHP version
167+
if: matrix.php-version == '8.3'
168+
continue-on-error: true
183169
run: ./phpunit --testsuite end-to-end
184170

185171
code-coverage:

0 commit comments

Comments
 (0)