From 55c35a7492c8a0edebeac960332763e2c0a68b6f Mon Sep 17 00:00:00 2001 From: Andre Khong Date: Fri, 14 May 2021 12:57:29 +0800 Subject: [PATCH] fix(android): register setIDFA function correctly for native bridge --- .../com/segment/analytics/reactnative/core/RNAnalytics.kt | 4 ---- .../segment/analytics/reactnative/core/RNAnalyticsModule.kt | 5 +++++ 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/packages/core/android/src/main/java/com/segment/analytics/reactnative/core/RNAnalytics.kt b/packages/core/android/src/main/java/com/segment/analytics/reactnative/core/RNAnalytics.kt index f78c79354..e73494c39 100644 --- a/packages/core/android/src/main/java/com/segment/analytics/reactnative/core/RNAnalytics.kt +++ b/packages/core/android/src/main/java/com/segment/analytics/reactnative/core/RNAnalytics.kt @@ -31,10 +31,6 @@ object RNAnalytics { private val integrations = mutableSetOf() private val onReadyCallbacks = mutableMapOf>() - fun setIDFA(idfa: String) { - // do nothing; iOS only. - } - fun addIntegration(integration: Integration.Factory) { integrations.add(integration) } diff --git a/packages/core/android/src/main/java/com/segment/analytics/reactnative/core/RNAnalyticsModule.kt b/packages/core/android/src/main/java/com/segment/analytics/reactnative/core/RNAnalyticsModule.kt index 7a63aaf5c..98f1a4869 100644 --- a/packages/core/android/src/main/java/com/segment/analytics/reactnative/core/RNAnalyticsModule.kt +++ b/packages/core/android/src/main/java/com/segment/analytics/reactnative/core/RNAnalyticsModule.kt @@ -284,6 +284,11 @@ class RNAnalyticsModule(context: ReactApplicationContext): ReactContextBaseJavaM @ReactMethod fun getAnonymousId(promise: Promise) = promise.resolve(analytics.getAnalyticsContext().traits().anonymousId()) + + @ReactMethod + fun setIDFA(idfa: String) { + // do nothing; iOS only. + } } private fun optionsFrom(context: ReadableMap?, integrations: ReadableMap?): Options {