From faf8de62e9d6d91eff4e3e8fa15720d440ccb3b8 Mon Sep 17 00:00:00 2001 From: Kadi Kraman Date: Thu, 13 Jun 2019 11:10:53 +0100 Subject: [PATCH] feat(ios): set trackAdvertising=true by default on ios --- packages/core/docs/classes/analytics.client.md | 2 +- packages/core/src/__tests__/configuration.spec.ts | 2 +- packages/core/src/analytics.ts | 4 ++-- packages/core/src/configuration.ts | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/core/docs/classes/analytics.client.md b/packages/core/docs/classes/analytics.client.md index 75c9777dd..ac448785a 100644 --- a/packages/core/docs/classes/analytics.client.md +++ b/packages/core/docs/classes/analytics.client.md @@ -142,7 +142,7 @@ ___ ▸ **getAnonymousId**(): `Promise`<`string`> -*Defined in [analytics.ts:305](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L305)* +*Defined in [analytics.ts:307](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L307)* Retrieve the anonymousId. diff --git a/packages/core/src/__tests__/configuration.spec.ts b/packages/core/src/__tests__/configuration.spec.ts index 0b8689581..89332f257 100644 --- a/packages/core/src/__tests__/configuration.spec.ts +++ b/packages/core/src/__tests__/configuration.spec.ts @@ -26,7 +26,7 @@ it('uses the default configuration', async () => { flushInterval: undefined }, ios: { - trackAdvertising: false, + trackAdvertising: true, trackDeepLinks: false } }) diff --git a/packages/core/src/analytics.ts b/packages/core/src/analytics.ts index 910af563d..13bf10f97 100644 --- a/packages/core/src/analytics.ts +++ b/packages/core/src/analytics.ts @@ -51,8 +51,8 @@ export module Analytics { ios?: { /** * Whether the analytics client should track advertisting info. - * - * Disabled by default. + * + * Enabled by default. */ trackAdvertising?: boolean /** diff --git a/packages/core/src/configuration.ts b/packages/core/src/configuration.ts index d3d208f67..375f7b8ff 100644 --- a/packages/core/src/configuration.ts +++ b/packages/core/src/configuration.ts @@ -10,7 +10,7 @@ const defaults = { flushInterval }), ios: ({ - trackAdvertising = false, + trackAdvertising = true, trackDeepLinks = false }: Partial) => ({ trackAdvertising,