From e343a68acf6bc77779abb7936aeaaa021f7fbc40 Mon Sep 17 00:00:00 2001 From: Brandon Weng <18161326+BrandonWeng@users.noreply.github.com> Date: Thu, 12 Jan 2023 15:53:35 -0500 Subject: [PATCH 1/4] done --- app/params/config.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/params/config.go b/app/params/config.go index 4ca5d71335..dfcb2bf416 100644 --- a/app/params/config.go +++ b/app/params/config.go @@ -21,7 +21,9 @@ const ( Bech32PrefixAccAddr = "sei" ) -var UnsafeBypassCommitTimeoutOverride = true +// Commits block as soon as we reach consensus instead of waiting for timeout, this may +// cause validators to not get their votes in time +var UnsafeBypassCommitTimeoutOverride = false var ( // Bech32PrefixAccPub defines the Bech32 prefix of an account's public key. @@ -93,11 +95,9 @@ func SetTendermintConfigs(config *tmcfg.Config) { config.Consensus.GossipTransactionKeyOnly = true config.Consensus.UnsafeProposeTimeoutOverride = 1 * time.Second config.Consensus.UnsafeProposeTimeoutDeltaOverride = 500 * time.Millisecond - config.Consensus.UnsafeVoteTimeoutOverride = 50 * time.Millisecond config.Consensus.UnsafeVoteTimeoutDeltaOverride = 500 * time.Millisecond config.Consensus.UnsafeCommitTimeoutOverride = 50 * time.Millisecond - config.Consensus.UnsafeBypassCommitTimeoutOverride = &UnsafeBypassCommitTimeoutOverride // Metrics config.Instrumentation.Prometheus = true From 09e33afb9f51a51e841d7c0aa72cf6b4f09b8289 Mon Sep 17 00:00:00 2001 From: Brandon Weng <18161326+BrandonWeng@users.noreply.github.com> Date: Thu, 12 Jan 2023 15:53:52 -0500 Subject: [PATCH 2/4] done --- app/params/config.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/params/config.go b/app/params/config.go index dfcb2bf416..81abeac590 100644 --- a/app/params/config.go +++ b/app/params/config.go @@ -97,7 +97,7 @@ func SetTendermintConfigs(config *tmcfg.Config) { config.Consensus.UnsafeProposeTimeoutDeltaOverride = 500 * time.Millisecond config.Consensus.UnsafeVoteTimeoutOverride = 50 * time.Millisecond config.Consensus.UnsafeVoteTimeoutDeltaOverride = 500 * time.Millisecond - config.Consensus.UnsafeCommitTimeoutOverride = 50 * time.Millisecond + config.Consensus.UnsafeCommitTimeoutOverride = 100 * time.Millisecond config.Consensus.UnsafeBypassCommitTimeoutOverride = &UnsafeBypassCommitTimeoutOverride // Metrics config.Instrumentation.Prometheus = true From 6c86d3be2297c6a607a56b0828b9852d71da000b Mon Sep 17 00:00:00 2001 From: Brandon Weng <18161326+BrandonWeng@users.noreply.github.com> Date: Thu, 12 Jan 2023 17:47:38 -0500 Subject: [PATCH 3/4] done --- app/params/config.go | 4 ++-- x/oracle/simulation/operations.go | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/params/config.go b/app/params/config.go index 81abeac590..79ff3fd8b0 100644 --- a/app/params/config.go +++ b/app/params/config.go @@ -21,8 +21,8 @@ const ( Bech32PrefixAccAddr = "sei" ) -// Commits block as soon as we reach consensus instead of waiting for timeout, this may -// cause validators to not get their votes in time +// UnsafeBypassCommitTimeoutOverride commits block as soon as we reach consensus instead of waiting +// for timeout, this may cause validators to not get their votes in time var UnsafeBypassCommitTimeoutOverride = false var ( diff --git a/x/oracle/simulation/operations.go b/x/oracle/simulation/operations.go index 3988c4b164..2028e73625 100644 --- a/x/oracle/simulation/operations.go +++ b/x/oracle/simulation/operations.go @@ -65,7 +65,7 @@ func WeightedOperations( } // SimulateMsgAggregateExchangeRateVote generates a MsgAggregateExchangeRateVote with random values. -//nolint: funlen +// nolint: funlen func SimulateMsgAggregateExchangeRateVote(ak types.AccountKeeper, bk types.BankKeeper, k keeper.Keeper) simtypes.Operation { return func( r *rand.Rand, app *baseapp.BaseApp, ctx sdk.Context, accs []simtypes.Account, chainID string, @@ -122,7 +122,7 @@ func SimulateMsgAggregateExchangeRateVote(ak types.AccountKeeper, bk types.BankK } // SimulateMsgDelegateFeedConsent generates a MsgDelegateFeedConsent with random values. -//nolint: funlen +// nolint: funlen func SimulateMsgDelegateFeedConsent(ak types.AccountKeeper, bk types.BankKeeper, k keeper.Keeper) simtypes.Operation { return func( r *rand.Rand, app *baseapp.BaseApp, ctx sdk.Context, accs []simtypes.Account, chainID string, From 3649f1c726eacad8686fb007a946dcf3443b8a2b Mon Sep 17 00:00:00 2001 From: Brandon Weng <18161326+BrandonWeng@users.noreply.github.com> Date: Thu, 12 Jan 2023 19:33:47 -0500 Subject: [PATCH 4/4] Update config.go --- app/params/config.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/params/config.go b/app/params/config.go index 79ff3fd8b0..69b0eca47b 100644 --- a/app/params/config.go +++ b/app/params/config.go @@ -93,11 +93,11 @@ func SetTendermintConfigs(config *tmcfg.Config) { config.Mempool.MaxTxBytes = 2048576 // Consensus Configs config.Consensus.GossipTransactionKeyOnly = true - config.Consensus.UnsafeProposeTimeoutOverride = 1 * time.Second + config.Consensus.UnsafeProposeTimeoutOverride = 5 * time.Second config.Consensus.UnsafeProposeTimeoutDeltaOverride = 500 * time.Millisecond config.Consensus.UnsafeVoteTimeoutOverride = 50 * time.Millisecond config.Consensus.UnsafeVoteTimeoutDeltaOverride = 500 * time.Millisecond - config.Consensus.UnsafeCommitTimeoutOverride = 100 * time.Millisecond + config.Consensus.UnsafeCommitTimeoutOverride = 50 * time.Millisecond config.Consensus.UnsafeBypassCommitTimeoutOverride = &UnsafeBypassCommitTimeoutOverride // Metrics config.Instrumentation.Prometheus = true