From 72bab3f327ba8b34a07a9810f923faf17332ada5 Mon Sep 17 00:00:00 2001 From: Yiming Zang Date: Tue, 21 Feb 2023 07:55:10 -0800 Subject: [PATCH] [oak] Use map[T]struct{}{} instead of map[T]bool for performance reason --- x/dex/types/genesis.go | 8 ++++---- x/dex/types/wasm/block_hooks.go | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/x/dex/types/genesis.go b/x/dex/types/genesis.go index c7e419d8e6..3d6b39086e 100644 --- a/x/dex/types/genesis.go +++ b/x/dex/types/genesis.go @@ -36,20 +36,20 @@ func (cs ContractState) Validate() error { return fmt.Errorf("empty contract addr") } // Check for duplicated ID in shortBook - longBookIDMap := make(map[uint64]bool) + longBookIDMap := make(map[uint64]struct{}) for _, elem := range cs.LongBookList { if _, ok := longBookIDMap[elem.Price.BigInt().Uint64()]; ok { return fmt.Errorf("duplicated price for longBook") } - longBookIDMap[elem.Price.BigInt().Uint64()] = true + longBookIDMap[elem.Price.BigInt().Uint64()] = struct{}{} } // Check for duplicated ID in shortBook - shortBookIDMap := make(map[uint64]bool) + shortBookIDMap := make(map[uint64]struct{}) for _, elem := range cs.ShortBookList { if _, ok := shortBookIDMap[elem.Price.BigInt().Uint64()]; ok { return fmt.Errorf("duplicated price for shortBook") } - shortBookIDMap[elem.Price.BigInt().Uint64()] = true + shortBookIDMap[elem.Price.BigInt().Uint64()] = struct{}{} } return nil } diff --git a/x/dex/types/wasm/block_hooks.go b/x/dex/types/wasm/block_hooks.go index b51d2bfc55..a67a527821 100644 --- a/x/dex/types/wasm/block_hooks.go +++ b/x/dex/types/wasm/block_hooks.go @@ -55,9 +55,9 @@ func NewContractOrderResult(contractAddr string) ContractOrderResult { func PopulateOrderPlacementResults(contractAddr string, orders []*types.Order, cancellations []*types.Cancellation, resultMap map[string]ContractOrderResult) { // get cancelled order ids - cancels := make(map[uint64]bool) + cancels := make(map[uint64]struct{}) for _, cancel := range cancellations { - cancels[cancel.Id] = true + cancels[cancel.Id] = struct{}{} } for _, order := range orders {