From 1ddaad9efd2694a4ad19818dbcc8a9e09558c4b1 Mon Sep 17 00:00:00 2001 From: Jeff Gerlach Date: Thu, 26 Oct 2017 17:23:27 -0600 Subject: [PATCH 1/2] Add pull request template file. --- .github/PULL_REQUEST_TEMPLATE | 37 +++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE new file mode 100644 index 0000000..844ea93 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE @@ -0,0 +1,37 @@ + + +**Description of the change**: + +**Reason for the change**: + +**Link to original source**: + +### Checklist + +Make sure all of these items are complete, or else the PR will be ineligible for a code review. + +- [ ] Code passes all existing [tests](https://github.com/sendgrid/smtpapi-nodejs/tree/master/test) +- [ ] Any new functionality added includes new unit tests in [`test/main.js`](https://github.com/sendgrid/smtpapi-nodejs/tree/master/test/main.js) +- [ ] Create or update example code to show the new functionality in action. +- [ ] All code, branch, and git naming and style conventions are followed (see [`CONTRIBUTING.md`](https://github.com/sendgrid/smtpapi-nodejs/blob/master/CONTRIBUTING.md#style-guidelines--naming-conventions)) +- [ ] Feature branch has been rebased off of the latest `master` branch. ( see [`CONTRIBUTING.md`](https://github.com/sendgrid/smtpapi-nodejs/blob/master/CONTRIBUTING.md#creating-a-pull-request) ). + +If you have questions, please send an email [Sendgrid](mailto:dx@sendgrid.com), or file a Github Issue in this repository. + + \ No newline at end of file From ea929955b0ae8e8caa28e49e82604321c5203e4f Mon Sep 17 00:00:00 2001 From: Jeff Gerlach <13844570+jeffgerlach@users.noreply.github.com> Date: Thu, 26 Oct 2017 22:57:36 -0600 Subject: [PATCH 2/2] Remove confusing docs link --- .github/PULL_REQUEST_TEMPLATE | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE index 844ea93..9e27f3b 100644 --- a/.github/PULL_REQUEST_TEMPLATE +++ b/.github/PULL_REQUEST_TEMPLATE @@ -29,9 +29,3 @@ Make sure all of these items are complete, or else the PR will be ineligible for - [ ] Feature branch has been rebased off of the latest `master` branch. ( see [`CONTRIBUTING.md`](https://github.com/sendgrid/smtpapi-nodejs/blob/master/CONTRIBUTING.md#creating-a-pull-request) ). If you have questions, please send an email [Sendgrid](mailto:dx@sendgrid.com), or file a Github Issue in this repository. - - \ No newline at end of file