Errors getting artifacts & runs should give exceptions

Author: alahiff

simvue/client.py

@@ -47,17 +47,14 @@ def get_run(self, run, system=False, tags=False, metadata=False):
                   'tags': tags,
                   'metadata': metadata}
 
-        try:
-            response = requests.get(f"{self._url}/api/runs", headers=self._headers, params=params)
-        except requests.exceptions.RequestException:
-            return None
+        response = requests.get(f"{self._url}/api/runs", headers=self._headers, params=params)
+        response.raise_for_status()
 
         if response.status_code == 200:
             return response.json()
 
         return None
 
-
     def get_runs(self, filters, system=False, tags=False, metadata=False, format='dict'):
         """
         Get runs
@@ -68,18 +65,16 @@ def get_runs(self, filters, system=False, tags=False, metadata=False, format='di
                   'tags': tags,
                   'metadata': metadata}
 
-        try:
-            response = requests.get(f"{self._url}/api/runs", headers=self._headers, params=params)
-        except requests.exceptions.RequestException:
-            return None
+        response = requests.get(f"{self._url}/api/runs", headers=self._headers, params=params)
+        response.raise_for_status()
 
         if response.status_code == 200:
             if format == 'dict':
                 return response.json()
             elif format == 'dataframe':
                 return to_dataframe(response.json())
             else:
-                return None 
+                raise Exception('invalid format specified')
 
         return None
 
@@ -89,10 +84,8 @@ def list_artifacts(self, run, category=None):
         """
         params = {'run': run}
 
-        try:
-            response = requests.get(f"{self._url}/api/artifacts", headers=self._headers, params=params)
-        except requests.exceptions.RequestException:
-            return None
+        response = requests.get(f"{self._url}/api/artifacts", headers=self._headers, params=params)
+        response.raise_for_status()
 
         if response.status_code == 200:
             return response.json()
@@ -105,21 +98,17 @@ def get_artifact(self, run, name, allow_pickle=False):
         """
         params = {'run': run, 'name': name}
 
-        try:
-            response = requests.get(f"{self._url}/api/artifacts", headers=self._headers, params=params)
-        except requests.exceptions.RequestException:
-            return None
+        response = requests.get(f"{self._url}/api/artifacts", headers=self._headers, params=params)
+        response.raise_for_status()
 
         if response.status_code != 200:
             return None
 
         url = response.json()[0]['url']
         mimetype = response.json()[0]['type']
 
-        try:
-            response = requests.get(url, timeout=DOWNLOAD_TIMEOUT)
-        except requests.exceptions.RequestException:
-            return None
+        response = requests.get(url, timeout=DOWNLOAD_TIMEOUT)
+        response.raise_for_status()
 
         content = Deserializer().deserialize(response.content, mimetype, allow_pickle)
         if content is not None:
@@ -133,10 +122,8 @@ def get_artifact_as_file(self, run, name, path='./'):
         """
         params = {'run': run, 'name': name}
 
-        try:
-            response = requests.get(f"{self._url}/api/artifacts", headers=self._headers, params=params)
-        except requests.exceptions.RequestException:
-            return None
+        response = requests.get(f"{self._url}/api/artifacts", headers=self._headers, params=params)
+        response.raise_for_status()
 
         if response.status_code == 200:
             if response.json():
@@ -159,10 +146,8 @@ def get_artifacts_as_files(self,
         if category:
             params['category'] = category
 
-        try:
-            response = requests.get(f"{self._url}/api/artifacts", headers=self._headers, params=params)
-        except requests.exceptions.RequestException:
-            return None
+        response = requests.get(f"{self._url}/api/artifacts", headers=self._headers, params=params)
+        response.raise_for_status()
 
         if not path:
             path = './'