From 7252a84c423ac6a60771c0eff50dc486fdea50c6 Mon Sep 17 00:00:00 2001 From: Benjamin Bossan Date: Fri, 23 Sep 2022 14:04:34 +0200 Subject: [PATCH] Add matplotlib and pandas as test dependencies Fixes #148 matplotlib and pandas are currently not test dependencies (only docs) but actually, tests cannot run without them. Not it should be possible to successfully run: pip install skops[tests] pytest skops (I tested locally with pip install -e .[tests]) Implementation There was already the possibility to declare the same dependency for multiple "extras" by using ", " as separator. Personally, I would have preferred a tuple like so: dependent_packages = { ..., ("pandas": ("1", ("docs", "tests"), None)), } but I guess the code is like this because sklearn does it the same. --- skops/_min_dependencies.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/skops/_min_dependencies.py b/skops/_min_dependencies.py index 08eef7fa..117e3f79 100644 --- a/skops/_min_dependencies.py +++ b/skops/_min_dependencies.py @@ -25,8 +25,8 @@ "numpydoc": ("1.0.0", "docs", None), "sphinx-prompt": ("1.3.0", "docs", None), "sphinx-issues": ("1.2.0", "docs", None), - "matplotlib": ("3.3", "docs", None), - "pandas": ("1", "docs", None), + "matplotlib": ("3.3", "docs, tests", None), + "pandas": ("1", "docs, tests", None), "typing_extensions": ("3.7", "install", "python_full_version < '3.8'"), }