From bc184a32c8a0b7cac184ffe6a5b4570fd6600411 Mon Sep 17 00:00:00 2001 From: Benjamin Bossan Date: Wed, 3 May 2023 12:45:42 +0200 Subject: [PATCH 1/2] FIX attempt at fixing broken GH workflow The GitHub action for testing the performance of persistence is broken since the last two weeks. The error is: > ModuleNotFoundError: No module named 'skops.io' This seems to be the same issue we already had previously with broken installs. Nothing relevant has been changed on the workflow yaml, so there is really no reason why it should suddenly break. This PR attempts to fix the issue by making the following changes: - Use Python 3.10 insteaad of 3.11 - Use pip install with -e flag - Explicitly call python3.10 instead of just python A PR hook was added to trigger this workflow, it should be removed before merging. --- .github/workflows/persistence-performance.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/persistence-performance.yml b/.github/workflows/persistence-performance.yml index be999636..a50387a8 100644 --- a/.github/workflows/persistence-performance.yml +++ b/.github/workflows/persistence-performance.yml @@ -1,6 +1,7 @@ name: Test performance and file size of skops persistence on: + pull_request: schedule: - cron: '0 9 * * 0' # every sunday at 9:00 UTC workflow_dispatch: @@ -18,13 +19,13 @@ jobs: - name: Set up Python uses: actions/setup-python@v4 with: - python-version: "3.11" + python-version: "3.10" - name: Install requirements run: | - pip install .[tests] + pip install -e .[tests] pip --version pip list - name: Run persistence performance checks - run: python scripts/check_persistence_performance.py + run: python3.10 scripts/check_persistence_performance.py - name: Run file size checks - run: python scripts/check_file_size.py + run: python3.10 scripts/check_file_size.py From 29cb3c47b0e51905380f8d69c2fe16ed35b8806d Mon Sep 17 00:00:00 2001 From: Benjamin Bossan Date: Wed, 3 May 2023 14:10:20 +0200 Subject: [PATCH 2/2] Remove pull request trigger It was just there for testing. --- .github/workflows/persistence-performance.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/persistence-performance.yml b/.github/workflows/persistence-performance.yml index a50387a8..342b0b2d 100644 --- a/.github/workflows/persistence-performance.yml +++ b/.github/workflows/persistence-performance.yml @@ -1,7 +1,6 @@ name: Test performance and file size of skops persistence on: - pull_request: schedule: - cron: '0 9 * * 0' # every sunday at 9:00 UTC workflow_dispatch: