From 54961d4d6d06536e0d02ec1221fff4fb072f3410 Mon Sep 17 00:00:00 2001 From: adrinjalali Date: Wed, 23 Oct 2024 17:12:55 +0200 Subject: [PATCH 1/6] MNT add python 3.13 tests --- .github/workflows/build-test.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index 4ef26a97..cb4a435e 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -29,6 +29,9 @@ jobs: sklearn_version: "1.4" numpy_version: "numpy" - python: "3.12" + sklearn_version: "1.5" + numpy_version: "numpy" + - python: "3.13" sklearn_version: "nightly" numpy_version: "numpy" From 2594e39c17f9bf165d6b98920bb9fa503527e6ec Mon Sep 17 00:00:00 2001 From: adrinjalali Date: Wed, 23 Oct 2024 17:16:35 +0200 Subject: [PATCH 2/6] remove model card deployer --- .../workflows/deploy-model-card-creator.yml | 47 ------------------- 1 file changed, 47 deletions(-) delete mode 100644 .github/workflows/deploy-model-card-creator.yml diff --git a/.github/workflows/deploy-model-card-creator.yml b/.github/workflows/deploy-model-card-creator.yml deleted file mode 100644 index 258269e8..00000000 --- a/.github/workflows/deploy-model-card-creator.yml +++ /dev/null @@ -1,47 +0,0 @@ -name: Deploy-Space-Creator - -on: - - push - - pull_request - -concurrency: - group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} - cancel-in-progress: true - -jobs: - deploy-space-creator: - runs-on: "ubuntu-latest" - if: "github.repository == 'skops-dev/skops'" - # Timeout: https://stackoverflow.com/a/59076067/4521646 - timeout-minutes: 5 - - steps: - - uses: actions/checkout@v4 - - - name: Set up Python - uses: actions/setup-python@v5 - with: - python-version: "3.10" - - - name: Install dependencies - run: | - pip install "pytest<8" - pip install -e .[docs,tests] - python --version - pip --version - pip list - shell: bash - - - name: Create test skops space creator app - # by default, deploy to skops CI - if: github.ref != 'refs/heads/main' - run: | - python spaces/deploy-skops-model-card-creator.py - - - name: Create main skops space creator app - # if HF_HUB_TOKEN_SKLEARN, use that instead of skops CI orga - if: github.ref == 'refs/heads/main' - env: - HF_HUB_TOKEN_SKLEARN: ${{ secrets.HF_HUB_TOKEN_SKLEARN }} - run: | - python spaces/deploy-skops-model-card-creator.py From c52f7149ca280bd172934d95eb5ac5857ef0255c Mon Sep 17 00:00:00 2001 From: adrinjalali Date: Wed, 23 Oct 2024 17:18:01 +0200 Subject: [PATCH 3/6] ... --- .github/workflows/build-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index cb4a435e..97ba5ccf 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -11,7 +11,7 @@ concurrency: jobs: pytest: runs-on: ${{ matrix.os }} - if: "github.repository == 'skops-dev/skops'" + if: github.repository == 'skops-dev/skops' strategy: fail-fast: false # need to see which ones fail matrix: From c113624f7bc74865c987305b69e7e4b9952ade00 Mon Sep 17 00:00:00 2001 From: adrinjalali Date: Wed, 23 Oct 2024 17:26:23 +0200 Subject: [PATCH 4/6] ... --- .github/workflows/build-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index 97ba5ccf..291f9b47 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -15,7 +15,7 @@ jobs: strategy: fail-fast: false # need to see which ones fail matrix: - os: [ubuntu-latest, windows-latest, macos-12] + os: [ubuntu-latest, windows-latest, macos-latest] python: ["3.9", "3.10", "3.11", "3.12"] # this is to make the CI run on different sklearn versions include: From 15b40b849e2cb8a313b977e4d9db1016be77d446 Mon Sep 17 00:00:00 2001 From: adrinjalali Date: Wed, 23 Oct 2024 17:27:54 +0200 Subject: [PATCH 5/6] ... --- .github/workflows/build-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index 291f9b47..c1f82b1f 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -16,7 +16,7 @@ jobs: fail-fast: false # need to see which ones fail matrix: os: [ubuntu-latest, windows-latest, macos-latest] - python: ["3.9", "3.10", "3.11", "3.12"] + python: ["3.9", "3.10", "3.11", "3.12", "3.13"] # this is to make the CI run on different sklearn versions include: - python: "3.9" From 62a4a999ff559ea14768d98e7d99296240757373 Mon Sep 17 00:00:00 2001 From: adrinjalali Date: Wed, 23 Oct 2024 17:32:16 +0200 Subject: [PATCH 6/6] ... --- .github/workflows/build-test.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index c1f82b1f..c0ce8c83 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -60,6 +60,9 @@ jobs: - name: Install dependencies run: | python -m pip install -U pip + if [ "${{ matrix.os }}" == "macos-latest" ]; then + brew install libomp + fi pip install "pytest<8" pip install "${{ matrix.numpy_version }}" if [ ${{ matrix.sklearn_version }} == "nightly" ];