From 1a4c1d3afa0a0ae5f4ccc4157e50b1d3c9086777 Mon Sep 17 00:00:00 2001 From: Tobias Preuss Date: Mon, 7 Sep 2020 21:44:10 +0200 Subject: [PATCH] Always recycle TypedArray. + See: https://developer.android.com/reference/android/content/res/TypedArray. --- .../colorpickerpreference/ColorPickerPreference.kt | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/colorpickerpreference/src/main/java/com/skydoves/colorpickerpreference/ColorPickerPreference.kt b/colorpickerpreference/src/main/java/com/skydoves/colorpickerpreference/ColorPickerPreference.kt index 13017a8..72db517 100644 --- a/colorpickerpreference/src/main/java/com/skydoves/colorpickerpreference/ColorPickerPreference.kt +++ b/colorpickerpreference/src/main/java/com/skydoves/colorpickerpreference/ColorPickerPreference.kt @@ -74,13 +74,21 @@ class ColorPickerPreference : Preference { private fun getAttrs(attrs: AttributeSet) { val typedArray = context.obtainStyledAttributes(attrs, R.styleable.ColorPickerPreference) - setTypeArray(typedArray) + try { + setTypeArray(typedArray) + } finally { + typedArray.recycle() + } } private fun getAttrs(attrs: AttributeSet, defStyle: Int) { val typedArray = context.obtainStyledAttributes(attrs, R.styleable.ColorPickerPreference, defStyle, 0) - setTypeArray(typedArray) + try { + setTypeArray(typedArray) + } finally { + typedArray.recycle() + } } private fun setTypeArray(typedArray: TypedArray) {