From e4ade41a78c85182f8fa6697e3afa1f054b19a12 Mon Sep 17 00:00:00 2001 From: William Bergamin Date: Thu, 26 Jun 2025 11:27:59 -0400 Subject: [PATCH 1/4] fix: sanic dependencies for tests --- requirements/adapter.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/requirements/adapter.txt b/requirements/adapter.txt index 6618f2b6f..2ecc8dd7e 100644 --- a/requirements/adapter.txt +++ b/requirements/adapter.txt @@ -14,7 +14,7 @@ Flask>=1,<4 Werkzeug>=2,<4 pyramid>=1,<3 sanic>=20,<21; python_version=="3.6" -sanic>=21,<24; python_version>"3.6" and python_version<="3.8" +sanic>=21,<23; python_version>"3.6" and python_version<="3.8" sanic>=21,<26; python_version>"3.8" starlette>=0.19.1,<1 tornado>=6,<7 From b856134b3614736fb4a7362519ba5ef69ffb8060 Mon Sep 17 00:00:00 2001 From: William Bergamin Date: Thu, 26 Jun 2025 11:51:31 -0400 Subject: [PATCH 2/4] Update tests.yml --- .github/workflows/tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index a1135f265..f73a40003 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -61,12 +61,12 @@ jobs: run: | # Requires async test dependencies pytest tests/adapter_tests/socket_mode/ --junitxml=reports/test_adapter_socket_mode.xml - - name: Run tests for HTTP Mode adapters (asyncio-based libraries) - run: | - pytest tests/adapter_tests_async/ --junitxml=reports/test_adapter_async.xml - name: Install all dependencies run: | pip install -r requirements/testing.txt + - name: Run tests for HTTP Mode adapters (asyncio-based libraries) + run: | + pytest tests/adapter_tests_async/ --junitxml=reports/test_adapter_async.xml - name: Run asynchronous tests run: | pytest tests/slack_bolt_async/ --junitxml=reports/test_slack_bolt_async.xml From 6dc60f9161c8d9f4b116f0641fd102f024d43e9e Mon Sep 17 00:00:00 2001 From: William Bergamin Date: Thu, 26 Jun 2025 11:56:19 -0400 Subject: [PATCH 3/4] make the tests not skip --- .github/workflows/tests.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index f73a40003..1d16d1a1b 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -53,10 +53,6 @@ jobs: - name: Install async dependencies run: | pip install -r requirements/async.txt - - name: Run tests for HTTP Mode adapters (ASGI) - run: | - # Requires async test dependencies - pytest tests/adapter_tests/asgi/ --junitxml=reports/test_adapter_asgi.xml - name: Run tests for Socket Mode adapters run: | # Requires async test dependencies @@ -64,6 +60,10 @@ jobs: - name: Install all dependencies run: | pip install -r requirements/testing.txt + - name: Run tests for HTTP Mode adapters (ASGI) + run: | + # Requires async test dependencies + pytest tests/adapter_tests/asgi/ --junitxml=reports/test_adapter_asgi.xml - name: Run tests for HTTP Mode adapters (asyncio-based libraries) run: | pytest tests/adapter_tests_async/ --junitxml=reports/test_adapter_async.xml From f4e2f8e8138ea7f2866f6c4b85df7e1cb1d694ae Mon Sep 17 00:00:00 2001 From: William Bergamin Date: Thu, 26 Jun 2025 12:23:32 -0400 Subject: [PATCH 4/4] Update adapter.txt --- requirements/adapter.txt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/requirements/adapter.txt b/requirements/adapter.txt index 2ecc8dd7e..b8cadb510 100644 --- a/requirements/adapter.txt +++ b/requirements/adapter.txt @@ -13,9 +13,14 @@ fastapi>=0.70.0,<1 Flask>=1,<4 Werkzeug>=2,<4 pyramid>=1,<3 + +# Sanic and its dependencies +# Note: Sanic imports tracerite with wild card versions +tracerite<1.1.2; python_version<="3.8" # older versions of python are not compatible with tracerite>1.1.2 sanic>=20,<21; python_version=="3.6" -sanic>=21,<23; python_version>"3.6" and python_version<="3.8" +sanic>=21,<24; python_version>"3.6" and python_version<="3.8" sanic>=21,<26; python_version>"3.8" + starlette>=0.19.1,<1 tornado>=6,<7 uvicorn<1 # The oldest version can vary among Python runtime versions