From 45760a8b34a43559539b2bd5a48aa689b0c9c1d7 Mon Sep 17 00:00:00 2001 From: Eden Zimbelman Date: Thu, 25 Sep 2025 17:02:50 -0700 Subject: [PATCH 1/4] ci: post regression notifications if scheduled tests do not succeed --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index e68997aef..167dc2ce4 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -86,7 +86,7 @@ jobs: name: Regression notifications runs-on: ubuntu-latest needs: build - if: failure() && github.ref == 'refs/heads/main' && github.event_name != 'workflow_dispatch' + if: ${{ !success() && github.ref == 'refs/heads/main' && github.event_name != 'workflow_dispatch' }} steps: - name: Send notifications of failing tests uses: slackapi/slack-github-action@91efab103c0de0a537f72a35f6b8cda0ee76bf0a # v2.1.1 From 30e01dc24c65c4b527c2e4ee31d1c3c8068e9762 Mon Sep 17 00:00:00 2001 From: Eden Zimbelman Date: Thu, 25 Sep 2025 17:08:39 -0700 Subject: [PATCH 2/4] test: confirm an erroring test posts a notification --- .github/workflows/tests.yml | 2 +- tests/slack_bolt/context/test_say.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 167dc2ce4..702df38da 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -86,7 +86,7 @@ jobs: name: Regression notifications runs-on: ubuntu-latest needs: build - if: ${{ !success() && github.ref == 'refs/heads/main' && github.event_name != 'workflow_dispatch' }} + if: ${{ !success() }} steps: - name: Send notifications of failing tests uses: slackapi/slack-github-action@91efab103c0de0a537f72a35f6b8cda0ee76bf0a # v2.1.1 diff --git a/tests/slack_bolt/context/test_say.py b/tests/slack_bolt/context/test_say.py index 9e465e5d5..7503d7c84 100644 --- a/tests/slack_bolt/context/test_say.py +++ b/tests/slack_bolt/context/test_say.py @@ -22,7 +22,7 @@ def teardown_method(self): def test_say(self): say = Say(client=self.web_client, channel="C111") response: SlackResponse = say(text="Hi there!") - assert response.status_code == 200 + assert response.status_code == 404 def test_say_unfurl_options(self): say = Say(client=self.web_client, channel="C111") From 3c81a299649d396279a3315fb21c68737ef09d8d Mon Sep 17 00:00:00 2001 From: Eden Zimbelman Date: Thu, 25 Sep 2025 17:12:34 -0700 Subject: [PATCH 3/4] revert: undo a breaking test to attempt a cancelled workflow --- tests/slack_bolt/context/test_say.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/slack_bolt/context/test_say.py b/tests/slack_bolt/context/test_say.py index 7503d7c84..9e465e5d5 100644 --- a/tests/slack_bolt/context/test_say.py +++ b/tests/slack_bolt/context/test_say.py @@ -22,7 +22,7 @@ def teardown_method(self): def test_say(self): say = Say(client=self.web_client, channel="C111") response: SlackResponse = say(text="Hi there!") - assert response.status_code == 404 + assert response.status_code == 200 def test_say_unfurl_options(self): say = Say(client=self.web_client, channel="C111") From ef5bc12a5b48d95db86fce936359577aaaafbf51 Mon Sep 17 00:00:00 2001 From: Eden Zimbelman Date: Thu, 25 Sep 2025 17:14:34 -0700 Subject: [PATCH 4/4] revert: return guards against sending notifications off main --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 702df38da..167dc2ce4 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -86,7 +86,7 @@ jobs: name: Regression notifications runs-on: ubuntu-latest needs: build - if: ${{ !success() }} + if: ${{ !success() && github.ref == 'refs/heads/main' && github.event_name != 'workflow_dispatch' }} steps: - name: Send notifications of failing tests uses: slackapi/slack-github-action@91efab103c0de0a537f72a35f6b8cda0ee76bf0a # v2.1.1