From 504909b6bb367a952c8e772a6a5965a068a888fb Mon Sep 17 00:00:00 2001 From: Ross McFarland Date: Sun, 31 Oct 2021 18:35:03 -0700 Subject: [PATCH] Use django.db close_old_connections over connections.close This opens things up to connection reuse via `CONN_MAX_AGE` and otherwise gets the full django connection cleanup behavior instead of explicitly closing the connection for each event handled. --- slack_bolt/adapter/django/handler.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/slack_bolt/adapter/django/handler.py b/slack_bolt/adapter/django/handler.py index 2862a380b..0a103d027 100644 --- a/slack_bolt/adapter/django/handler.py +++ b/slack_bolt/adapter/django/handler.py @@ -54,15 +54,15 @@ def to_django_response(bolt_resp: BoltResponse) -> HttpResponse: return resp -from django.db import connections +from django.db import close_old_connections def release_thread_local_connections(logger: Logger, execution_type: str): - connections.close_all() + close_old_connections() if logger.level <= logging.DEBUG: current: Thread = current_thread() logger.debug( - f"Released thread-bound DB connections (thread name: {current.name}, execution type: {execution_type})" + f"close_old_connections called to manage thread-bound DB connections (thread name: {current.name}, execution type: {execution_type})" ) @@ -124,8 +124,8 @@ def __init__(self, app: App): # type: ignore Bolt skipped to set it to slack_sdk.adapter.django.DjangoListenerCompletionHandler. We strongly recommend having the following lines of code in your listener_completion_handler: - from django.db import connections - connections.close_all() + from django.db import close_old_connections + close_old_connections() """ self.app.logger.warning(message) return