diff --git a/modules/smartadserverBidAdapter.js b/modules/smartadserverBidAdapter.js index bb9364c72c3..577478e7ab3 100644 --- a/modules/smartadserverBidAdapter.js +++ b/modules/smartadserverBidAdapter.js @@ -178,7 +178,7 @@ export const spec = { */ getUserSyncs: function (syncOptions, serverResponses) { const syncs = []; - if (syncOptions.iframeEnabled && serverResponses.length > 0) { + if (syncOptions.iframeEnabled && serverResponses.length > 0 && serverResponses[0].body.cSyncUrl != null) { syncs.push({ type: 'iframe', url: serverResponses[0].body.cSyncUrl diff --git a/modules/smartadserverBidAdapter.md b/modules/smartadserverBidAdapter.md index 05e29359fd2..7a2381ac9f1 100644 --- a/modules/smartadserverBidAdapter.md +++ b/modules/smartadserverBidAdapter.md @@ -110,11 +110,11 @@ Please reach out to your Technical account manager for more information. renderer: { url: 'https://acdn.adnxs.com/video/outstream/ANOutstreamVideo.js', render: function (bid) { - bid.renderer.push(() => { - ANOutstreamVideo.renderAd({ + bid.renderer.push(() => { + ANOutstreamVideo.renderAd({ targetId: bid.adUnitCode, - adResponse: bid - }); + adResponse: bid + }); }); } }, @@ -133,4 +133,34 @@ Please reach out to your Technical account manager for more information. } }] }; +``` + +## Double Mediatype Setup (Banner & Video) + +``` + var adUnits = [{ + code: 'prebid_tag_001', + mediaTypes: { + banner: { + sizes: [[300,250]] + }, + video: { + context: 'outstream', + playerSize: [640, 480] + } + }, + bids: [{ + bidder: 'smartadserver', + params: { + domain: 'https://prg.smartadserver.com', + siteId: 411951, + pageId: 1383641, + formatId: 84313, + target: 'iid=8984466', + video: { + protocol: 6, // Stands for "up to VAST 3". For "up to VAST 4" it is 8 + } + } + }] + }]; ``` \ No newline at end of file diff --git a/test/spec/modules/smartadserverBidAdapter_spec.js b/test/spec/modules/smartadserverBidAdapter_spec.js index 749de43b9af..98cf60dc27a 100644 --- a/test/spec/modules/smartadserverBidAdapter_spec.js +++ b/test/spec/modules/smartadserverBidAdapter_spec.js @@ -153,6 +153,22 @@ describe('Smart bid adapter tests', function () { } }; + var BID_RESPONSE_IFRAME_SYNC_MISSING_CSYNC = { + body: { + cpm: 12, + width: 300, + height: 250, + creativeId: 'zioeufg', + currency: 'GBP', + isNetCpm: true, + ttl: 300, + adUrl: 'http://awesome.fake.url', + ad: '< --- awesome script --- >', + cSyncUrl: null, + isNoAd: false + } + }; + it('Verify build request', function () { config.setConfig({ 'currency': { @@ -302,6 +318,11 @@ describe('Smart bid adapter tests', function () { iframeEnabled: true }, []); expect(syncs).to.have.lengthOf(0); + + syncs = spec.getUserSyncs({ + iframeEnabled: true + }, [BID_RESPONSE_IFRAME_SYNC_MISSING_CSYNC]); + expect(syncs).to.have.lengthOf(0); }); it('Verifies user sync using dspPixels', function () {