From 2f760a4688a0191969561dedbc130c82d95e9666 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joan=20Marc=C3=A8=20i=20Igual?= Date: Thu, 4 Aug 2022 13:19:50 +0200 Subject: [PATCH 1/2] Change default submodules and fix install issue The wrong target was used for installation of targets --- CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index d1a045ab..7a7592b5 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -6,7 +6,7 @@ PROJECT(sioclient option(BUILD_SHARED_LIBS "Build the shared library" OFF) option(BUILD_UNIT_TESTS "Builds unit tests target" OFF) -option(USE_SUBMODULES "Use source in local submodules instead of system libraries" OFF) +option(USE_SUBMODULES "Use source in local submodules instead of system libraries" ON) set(MAJOR 1) set(MINOR 6) @@ -158,7 +158,7 @@ install( FILES "${CMAKE_CURRENT_BINARY_DIR}/sioclient/sioclientConfig.cmake" "${CMAKE_CURRENT_BINARY_DIR}/sioclient/sioclientConfigVersion.cmake" - "${CMAKE_CURRENT_BINARY_DIR}/sioclient/sioclientConfigTargets.cmake" + "${CMAKE_CURRENT_BINARY_DIR}/sioclient/sioclientTargets.cmake" DESTINATION ${ConfigPackageLocation} ) From 45e49ad6e7456ba3e1d75e62c2c5d6ddab3c9e1e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joan=20Marc=C3=A8=20i=20Igual?= Date: Thu, 4 Aug 2022 13:24:18 +0200 Subject: [PATCH 2/2] Disable flag as we changed the default --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7001ae61..c8e65c60 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,4 +23,4 @@ jobs: submodule_update: ON run_tests: ON unit_test_build: -DBUILD_UNIT_TESTS=ON - cmake_args: -DCMAKE_CXX_FLAGS=-std=c++11;-DUSE_SUBMODULES=ON + cmake_args: -DCMAKE_CXX_FLAGS=-std=c++11