Merge pull request #2185 from kz6fittycent/master

Snap core24 upgrade

Author: allmightyspiff

.github/workflows/test-snap-can-build.yml

@@ -0,0 +1,28 @@
+name: Snap Builds
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+    
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node-version: [20.x]    
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - uses: snapcore/action-build@v1
+        id: build
+
+      - uses: diddlesnaps/snapcraft-review-action@v1
+        with:
+          snap: ${{ steps.build.outputs.snap }}
+          isClassic: 'false'
+          # Plugs and Slots declarations to override default denial (requires store assertion to publish)
+          # plugs: ./plug-declaration.json
+          # slots: ./slot-declaration.json

README.rst

@@ -10,7 +10,8 @@ SoftLayer API Python Client
     :target: https://coveralls.io/github/softlayer/softlayer-python?branch=master
 .. image:: https://snapcraft.io//slcli/badge.svg
     :target: https://snapcraft.io/slcli
-
+.. image:: https://https://github.com/softlayer/softlayer-python/workflows/Snap%20Builds/badge.svg
+    :target: https://github.com/softlayer/softlayer-python/actions?query=workflow:"Snap+Builds"
 
 This library provides a simple Python client to interact with `SoftLayer's
 XML-RPC API <https://softlayer.github.io/reference/softlayerapi>`_.

snap/local/slcli.png

@@ -6,11 +6,32 @@ description: |
     SLCLI documentation can be found here: https://softlayer-python.readthedocs.io/en/latest/
 
 license: MIT
-
-base: core22
+website: https://www.ibm.com/cloud
+source-code: https://github.com/softlayer/softlayer-python
+issues: https://github.com/softlayer/softlayer-python/issues
+contact: https://github.com/softlayer/softlayer-python
+icon: snap/local/slcli.png
+base: core24
 grade: stable 
 confinement: strict
 
+platforms:
+  amd64:
+    build-on: [amd64]
+    build-for: [amd64]
+  arm64:
+    build-on: [arm64]
+    build-for: [arm64]
+  armhf:
+    build-on: [armhf]
+    build-for: [armhf]
+  ppc64el:
+    build-on: [ppc64el]
+    build-for: [ppc64el]
+  s390x:
+    build-on: [s390x]
+    build-for: [s390x]
+
 apps:
   slcli:
     command: bin/slcli
@@ -25,10 +46,10 @@ parts:
   slcli:
     source: https://github.com/softlayer/softlayer-python
     source-type: git
-    plugin: python
+    plugin: python      
     override-pull: |
-      snapcraftctl pull
-      snapcraftctl set-version "$(git describe --tags | sed 's/^v//')"
+      craftctl default
+      craftctl set version="$(git describe --tags | sed 's/^v//')"
     
     build-packages:
       - python3