Skip to content

Commit 4f74ed7

Browse files
tobonexkv2019i
authored andcommitted
volume: remove buffer_acquire from volume
remove buffer ops from volume module this is a continuation of changes from commit 4a03699 Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
1 parent cd7e3d3 commit 4f74ed7

File tree

3 files changed

+10
-28
lines changed

3 files changed

+10
-28
lines changed

src/audio/volume/volume.c

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -638,7 +638,6 @@ static int volume_prepare(struct processing_module *mod,
638638
struct module_data *md = &mod->priv;
639639
struct comp_dev *dev = mod->dev;
640640
struct comp_buffer *sourceb, *sinkb;
641-
struct comp_buffer *source_c, *sink_c;
642641
uint32_t sink_period_bytes;
643642
int ret;
644643
int i;
@@ -653,20 +652,15 @@ static int volume_prepare(struct processing_module *mod,
653652
sourceb = list_first_item(&dev->bsource_list,
654653
struct comp_buffer, sink_list);
655654

656-
sink_c = buffer_acquire(sinkb);
657-
source_c = buffer_acquire(sourceb);
658-
659-
volume_set_alignment(&source_c->stream, &sink_c->stream);
660-
661-
buffer_release(source_c);
655+
volume_set_alignment(&sourceb->stream, &sinkb->stream);
662656

663657
/* get sink period bytes */
664-
sink_period_bytes = audio_stream_period_bytes(&sink_c->stream,
658+
sink_period_bytes = audio_stream_period_bytes(&sinkb->stream,
665659
dev->frames);
666660

667-
if (audio_stream_get_size(&sink_c->stream) < sink_period_bytes) {
661+
if (audio_stream_get_size(&sinkb->stream) < sink_period_bytes) {
668662
comp_err(dev, "volume_prepare(): sink buffer size %d is insufficient < %d",
669-
audio_stream_get_size(&sink_c->stream), sink_period_bytes);
663+
audio_stream_get_size(&sinkb->stream), sink_period_bytes);
670664
ret = -ENOMEM;
671665
goto err;
672666
}
@@ -680,7 +674,7 @@ static int volume_prepare(struct processing_module *mod,
680674
goto err;
681675
}
682676

683-
cd->zc_get = vol_get_zc_function(dev, sink_c);
677+
cd->zc_get = vol_get_zc_function(dev, sinkb);
684678
if (!cd->zc_get) {
685679
comp_err(dev, "volume_prepare(): invalid cd->zc_get");
686680
ret = -EINVAL;
@@ -695,16 +689,14 @@ static int volume_prepare(struct processing_module *mod,
695689
*/
696690
cd->ramp_finished = false;
697691

698-
cd->channels = audio_stream_get_channels(&sink_c->stream);
692+
cd->channels = audio_stream_get_channels(&sinkb->stream);
699693
if (cd->channels > SOF_IPC_MAX_CHANNELS) {
700694
ret = -EINVAL;
701695
goto err;
702696
}
703697

704698
cd->sample_rate_inv = (int32_t)(1000LL * INT32_MAX /
705-
audio_stream_get_rate(&sink_c->stream));
706-
707-
buffer_release(sink_c);
699+
audio_stream_get_rate(&sinkb->stream));
708700

709701
for (i = 0; i < cd->channels; i++) {
710702
cd->volume[i] = cd->vol_min;
@@ -725,7 +717,6 @@ static int volume_prepare(struct processing_module *mod,
725717
return 0;
726718

727719
err:
728-
buffer_release(sink_c);
729720
comp_set_state(dev, COMP_TRIGGER_RESET);
730721
return ret;
731722
}

src/audio/volume/volume_ipc3.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ LOG_MODULE_DECLARE(volume, CONFIG_SOF_LOG_LEVEL);
3737
void set_volume_process(struct vol_data *cd, struct comp_dev *dev, bool source_or_sink)
3838
{
3939
struct comp_buffer *bufferb;
40-
struct comp_buffer *buffer_c;
4140

4241
if (source_or_sink)
4342
bufferb = list_first_item(&dev->bsource_list,
@@ -46,10 +45,7 @@ void set_volume_process(struct vol_data *cd, struct comp_dev *dev, bool source_o
4645
bufferb = list_first_item(&dev->bsink_list,
4746
struct comp_buffer, source_list);
4847

49-
buffer_c = buffer_acquire(bufferb);
50-
cd->scale_vol = vol_get_processing_function(dev, buffer_c, cd);
51-
52-
buffer_release(buffer_c);
48+
cd->scale_vol = vol_get_processing_function(dev, bufferb, cd);
5349
}
5450

5551
/**

src/audio/volume/volume_ipc4.c

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,6 @@ int volume_get_config(struct processing_module *mod,
366366
static int volume_params(struct processing_module *mod)
367367
{
368368
struct sof_ipc_stream_params *params = mod->stream_params;
369-
struct comp_buffer *sink_c, *source_c;
370369
struct comp_buffer *sinkb, *sourceb;
371370
struct comp_dev *dev = mod->dev;
372371

@@ -378,14 +377,10 @@ static int volume_params(struct processing_module *mod)
378377

379378
/* volume component will only ever have 1 sink buffer */
380379
sinkb = list_first_item(&dev->bsink_list, struct comp_buffer, source_list);
381-
sink_c = buffer_acquire(sinkb);
382-
ipc4_update_buffer_format(sink_c, &mod->priv.cfg.base_cfg.audio_fmt);
383-
buffer_release(sink_c);
380+
ipc4_update_buffer_format(sinkb, &mod->priv.cfg.base_cfg.audio_fmt);
384381

385382
sourceb = list_first_item(&dev->bsource_list, struct comp_buffer, sink_list);
386-
source_c = buffer_acquire(sourceb);
387-
ipc4_update_buffer_format(source_c, &mod->priv.cfg.base_cfg.audio_fmt);
388-
buffer_release(source_c);
383+
ipc4_update_buffer_format(sourceb, &mod->priv.cfg.base_cfg.audio_fmt);
389384

390385
return 0;
391386
}

0 commit comments

Comments
 (0)