From 6f67dbc7bc8b46de53ae8d1d206b2db8903fb150 Mon Sep 17 00:00:00 2001 From: Jared Norman Date: Fri, 8 Sep 2023 10:47:41 -0700 Subject: [PATCH] Remove dependency on the webdrivers gem webdrivers no longer works with recent versions of Chrome. Recent versions of selenium-webdriver (newer than 4.11) achieve the same effect. One caveat with this change: it implicitly requires Ruby 3 as that's the requirement for selenium-webdriver 4.11+. --- lib/solidus_dev_support/rspec/capybara.rb | 2 -- solidus_dev_support.gemspec | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/solidus_dev_support/rspec/capybara.rb b/lib/solidus_dev_support/rspec/capybara.rb index b4bf2dbb..3f548655 100644 --- a/lib/solidus_dev_support/rspec/capybara.rb +++ b/lib/solidus_dev_support/rspec/capybara.rb @@ -1,7 +1,5 @@ # frozen_string_literal: true -require 'webdrivers/chromedriver' - # Allow to override the initial windows size CAPYBARA_WINDOW_SIZE = ENV.fetch('CAPYBARA_WINDOW_SIZE', '1920x1080').split('x', 2).map(&:to_i) CAPYBARA_WINDOW_WIDTH = CAPYBARA_WINDOW_SIZE[0] diff --git a/solidus_dev_support.gemspec b/solidus_dev_support.gemspec index a859958b..0aea15b5 100644 --- a/solidus_dev_support.gemspec +++ b/solidus_dev_support.gemspec @@ -45,6 +45,6 @@ Gem::Specification.new do |spec| spec.add_dependency 'rubocop-performance', '~> 1.5' spec.add_dependency 'rubocop-rails', '~> 2.3' spec.add_dependency 'rubocop-rspec', '~> 2.0' + spec.add_dependency 'selenium-webdriver', '~> 4.11' spec.add_dependency 'solidus_core', ['>= 2.0', '< 5'] - spec.add_dependency 'webdrivers', '>= 4.4' end