From ba2b8205ac19db9968f6529de04f18a945129803 Mon Sep 17 00:00:00 2001 From: Martin Meyerhoff Date: Thu, 18 Jan 2024 14:04:01 +0100 Subject: [PATCH] Allow rspec-rails 6 rspec-rails < 6.0.2 is incompatible with Rails 7.1 because of stricter view path typecasting in Rails 7.1. This bug is fixed in rspec-rails 6.0.2. Without this, controller specs in extensions will break. https://github.com/rspec/rspec-rails/pull/2631 This also raises the minimum version to rspec-rails 5 as Solidus 3.x needs Rails > 5.2, and rspec-rails 5 is the version for that Rails version. --- solidus_dev_support.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/solidus_dev_support.gemspec b/solidus_dev_support.gemspec index 9652bd63..a9757d0d 100644 --- a/solidus_dev_support.gemspec +++ b/solidus_dev_support.gemspec @@ -40,7 +40,7 @@ Gem::Specification.new do |spec| spec.add_dependency 'github_changelog_generator', '~> 1.15' spec.add_dependency 'puma', '>= 4.3', '< 7.0' spec.add_dependency 'rspec_junit_formatter' - spec.add_dependency 'rspec-rails', '>= 4.0.0.beta3', '< 6.0' + spec.add_dependency 'rspec-rails', '>= 5.0', '< 7.0' spec.add_dependency 'rubocop', '~> 1.0' spec.add_dependency 'rubocop-performance', '~> 1.5' spec.add_dependency 'rubocop-rails', '~> 2.3'