From 54dc420c753378de715bad1b21133b99885e0bff Mon Sep 17 00:00:00 2001 From: Jonathan Go Date: Mon, 2 Apr 2018 14:32:54 -0400 Subject: [PATCH 1/6] added video docs --- dev-docs/bidders.md | 1 + dev-docs/bidders/sonobi.md | 140 +++++++++++++++++++++++++++++++++++++ 2 files changed, 141 insertions(+) diff --git a/dev-docs/bidders.md b/dev-docs/bidders.md index 1d545f00a4..c0835f01eb 100644 --- a/dev-docs/bidders.md +++ b/dev-docs/bidders.md @@ -115,6 +115,7 @@ The following parameters in the `bidResponse` object are common across all bidde | stickyadstv | native | | | tremor | video | | | unruly | video,native | | +| sonobi | video | x | diff --git a/dev-docs/bidders/sonobi.md b/dev-docs/bidders/sonobi.md index 160d3be5c6..ac56d8ea60 100644 --- a/dev-docs/bidders/sonobi.md +++ b/dev-docs/bidders/sonobi.md @@ -32,3 +32,143 @@ The `ad_unit` and `placement_id` are **mutually exclusive** but at least one is If you pass the optional `sizes` Array in your bid params it will override the global config sizes for the Sonobi Adapter only. The `hfa` parameter requires your Sonobi Account Manager to enable this feature for you. Please contact them for further information. + +### Example Video Implementation with VideoJs +``` + + + + + + Prebid.js video adUnit example + + + + + + + + + + + + + + + + + + +

Prebid Video -- video.js

+ +
+ + +
+ + + + + +``` + From 12f848186dbca45508e1ffa8d082d8ac33359064 Mon Sep 17 00:00:00 2001 From: Jonathan Go Date: Mon, 2 Apr 2018 16:39:00 -0400 Subject: [PATCH 2/6] updated example imeplementation to use always on campaign --- dev-docs/bidders/sonobi.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dev-docs/bidders/sonobi.md b/dev-docs/bidders/sonobi.md index ac56d8ea60..99e050be9b 100644 --- a/dev-docs/bidders/sonobi.md +++ b/dev-docs/bidders/sonobi.md @@ -67,7 +67,7 @@ The `hfa` parameter requires your Sonobi Account Manager to enable this feature var videoAdUnit = { code: 'video1', - sizes: [640,480], + sizes: [640, 480], mediaTypes: { video: {context: 'instream'} }, @@ -75,7 +75,12 @@ The `hfa` parameter requires your Sonobi Account Manager to enable this feature { bidder: 'sonobi', params: { + sizes: [], placement_id: '92e95368e86639dbd86d', + video: { + skipppable: false, + playback_methods: ['auto_play_sound_off'] + } } } ] From fbb1dbd688825183071152dad9f54ff0d4485674 Mon Sep 17 00:00:00 2001 From: Jonathan Go Date: Tue, 3 Apr 2018 08:56:40 -0400 Subject: [PATCH 3/6] removed unneeded values from params --- dev-docs/bidders/sonobi.md | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/dev-docs/bidders/sonobi.md b/dev-docs/bidders/sonobi.md index 99e050be9b..7a495e1e45 100644 --- a/dev-docs/bidders/sonobi.md +++ b/dev-docs/bidders/sonobi.md @@ -76,11 +76,7 @@ The `hfa` parameter requires your Sonobi Account Manager to enable this feature bidder: 'sonobi', params: { sizes: [], - placement_id: '92e95368e86639dbd86d', - video: { - skipppable: false, - playback_methods: ['auto_play_sound_off'] - } + placement_id: '92e95368e86639dbd86d' } } ] From e10e3b5bb8892e6300a337214dc011379350fbae Mon Sep 17 00:00:00 2001 From: Jonathan Go Date: Wed, 4 Apr 2018 14:02:58 -0400 Subject: [PATCH 4/6] added timeout to videojs --- dev-docs/bidders/sonobi.md | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/dev-docs/bidders/sonobi.md b/dev-docs/bidders/sonobi.md index 7a495e1e45..87a65975f3 100644 --- a/dev-docs/bidders/sonobi.md +++ b/dev-docs/bidders/sonobi.md @@ -76,7 +76,11 @@ The `hfa` parameter requires your Sonobi Account Manager to enable this feature bidder: 'sonobi', params: { sizes: [], - placement_id: '92e95368e86639dbd86d' + placement_id: '92e95368e86639dbd86d', + video: { + skipppable: false, + playback_methods: ['auto_play_sound_off'] + } } } ] @@ -85,7 +89,7 @@ The `hfa` parameter requires your Sonobi Account Manager to enable this feature pbjs.que.push(function(){ pbjs.addAdUnits(videoAdUnit); pbjs.requestBids({ - timeout : 700, + timeout : 100000, bidsBackHandler : function(bids) { var videoUrl = pbjs.adServers.dfp.buildVideoUrl({ adUnit: videoAdUnit, @@ -158,6 +162,7 @@ The `hfa` parameter requires your Sonobi Account Manager to enable this feature adTagUrl: url, playAdAlways: true, verbosity: 4, + timeout: 100000, vpaidFlashLoaderPath: "https://github.com/MailOnline/videojs-vast-vpaid/blob/RELEASE/bin/VPAIDFlash.swf?raw=true", autoplay: true, }); @@ -171,5 +176,6 @@ The `hfa` parameter requires your Sonobi Account Manager to enable this feature + ``` From 03fe3e18fd91459737ef4ad328aaf06efc5d759b Mon Sep 17 00:00:00 2001 From: Jonathan Go Date: Wed, 18 Apr 2018 13:35:32 -0400 Subject: [PATCH 5/6] removed unused video params in the example videoAdunit. Added media_types: video to sonobi docs --- dev-docs/bidders/sonobi.md | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/dev-docs/bidders/sonobi.md b/dev-docs/bidders/sonobi.md index 87a65975f3..95fd163927 100644 --- a/dev-docs/bidders/sonobi.md +++ b/dev-docs/bidders/sonobi.md @@ -8,6 +8,7 @@ hide: true biddercode: sonobi biddercode_longer_than_12: false prebid_1_0_supported : true +media_types: video --- ### Note: @@ -76,11 +77,7 @@ The `hfa` parameter requires your Sonobi Account Manager to enable this feature bidder: 'sonobi', params: { sizes: [], - placement_id: '92e95368e86639dbd86d', - video: { - skipppable: false, - playback_methods: ['auto_play_sound_off'] - } + placement_id: '92e95368e86639dbd86d' } } ] From db8b60ab233b0889b0f70425369386a09f6a2fc3 Mon Sep 17 00:00:00 2001 From: Jonathan Go Date: Wed, 18 Apr 2018 15:48:55 -0400 Subject: [PATCH 6/6] removed video example from the sonobi bidder param doc. Added sonobi video example under examples/bidders --- dev-docs/bidders/sonobi.md | 144 +-------------------- examples/bidders/sonobi-video-example.html | 136 +++++++++++++++++++ 2 files changed, 138 insertions(+), 142 deletions(-) create mode 100644 examples/bidders/sonobi-video-example.html diff --git a/dev-docs/bidders/sonobi.md b/dev-docs/bidders/sonobi.md index 95fd163927..147cfb5887 100644 --- a/dev-docs/bidders/sonobi.md +++ b/dev-docs/bidders/sonobi.md @@ -34,145 +34,5 @@ If you pass the optional `sizes` Array in your bid params it will override the g The `hfa` parameter requires your Sonobi Account Manager to enable this feature for you. Please contact them for further information. -### Example Video Implementation with VideoJs -``` - - - - - - Prebid.js video adUnit example - - - - - - - - - - - - - - - - - - -

Prebid Video -- video.js

- -
- - -
- - - - - - -``` - +### Video Example +[Sonobi Video](http://prebid.org/examples/bidders/sonobi-video-example.html) diff --git a/examples/bidders/sonobi-video-example.html b/examples/bidders/sonobi-video-example.html new file mode 100644 index 0000000000..199ac10faf --- /dev/null +++ b/examples/bidders/sonobi-video-example.html @@ -0,0 +1,136 @@ + + + + + + Sonobi - Prebid.js video adUnit example + + + + + + + + + + + + + + + + + + +

Sonobi Prebid Video -- video.js

+ +
+ + +
+ + + +