feat: remove code host search box integration

(The location bar search autocomplete feature remains.)

Reason: The experience was not great (it opened results in a new window) and it was disabled by default. It is not worth maintaining a feature that is disabled by default and that has no current plan for improvement.

BREAKING CHANGE: The "Open a new window with Sourcegraph search results when you perform a search on your code host." feature was removed. See https://docs.sourcegraph.com/integration/browser_search_engine for a better solution that is provided by the browser extension.

Author: sqs

README.md

@@ -21,7 +21,6 @@ The tooltips include features like:
 - symbol type information & documentation
 - go to definition & find references (currently for Go, Java, TypeScript, JavaScript, Python)
 - find references
-- improved search functionality
 
 #### 🚀 Install: [**Sourcegraph for Chrome**](https://chrome.google.com/webstore/detail/sourcegraph/dgjhfomjieaadpoljlnidmbgkdffpack) — [**Sourcegraph for Firefox**](https://addons.mozilla.org/en-US/firefox/addon/sourcegraph/)
 

src/browser/types.ts

@@ -44,7 +44,6 @@ export interface StorageItems {
     phabricatorURL: string
     inlineSymbolSearchEnabled: boolean
     renderMermaidGraphsEnabled: boolean
-    executeSearchEnabled: boolean
     identity: string
     serverUrls: string[]
     enterpriseUrls: string[]
@@ -86,7 +85,6 @@ export const defaultStorageItems: StorageItems = {
     phabricatorURL: '',
     inlineSymbolSearchEnabled: true,
     renderMermaidGraphsEnabled: false,
-    executeSearchEnabled: false,
     identity: '',
     enterpriseUrls: [],
     serverUserId: '',

src/extension/scripts/inject.tsx

@@ -7,7 +7,6 @@ import * as runtime from '../../browser/runtime'
 import storage from '../../browser/storage'
 import { StorageItems } from '../../browser/types'
 import {
-    setExecuteSearchEnabled,
     setInlineSymbolSearchEnabled,
     setRenderMermaidGraphsEnabled,
     setSourcegraphUrl,
@@ -81,7 +80,6 @@ function injectApplication(): void {
             setInlineSymbolSearchEnabled(
                 items.inlineSymbolSearchEnabled === undefined ? false : items.inlineSymbolSearchEnabled
             )
-            setExecuteSearchEnabled(items.executeSearchEnabled === undefined ? true : items.executeSearchEnabled)
             injectGitHubApplication(extensionMarker)
         } else if (isSourcegraphServer || /^https?:\/\/(www.)?sourcegraph.com/.test(href)) {
             setSourcegraphUrl(sourcegraphServerUrl)

src/libs/code_intelligence/code_intelligence.tsx

@@ -31,7 +31,6 @@ import { gitlabCodeHost } from '../gitlab/code_intelligence'
 import { phabricatorCodeHost } from '../phabricator/code_intelligence'
 import { findCodeViews, getContentOfCodeView } from './code_views'
 import { applyDecoration, Controllers, initializeExtensions } from './extensions'
-import { initSearch, SearchFeature } from './search'
 
 /**
  * Defines a type of code view a given code host can have. It tells us how to
@@ -125,11 +124,6 @@ export interface CodeHost {
      */
     adjustOverlayPosition?: (position: OverlayPosition) => OverlayPosition
 
-    /**
-     * Implementation of the search feature for a code host.
-     */
-    search?: SearchFeature
-
     // Extensions related input
 
     /**
@@ -326,10 +320,6 @@ export interface ResolvedCodeView extends CodeViewWithOutSelector {
 }
 
 function handleCodeHost(codeHost: CodeHost): Subscription {
-    if (codeHost.search) {
-        initSearch(codeHost.search)
-    }
-
     const documentsSubject = new BehaviorSubject<TextDocumentItem[] | null>([])
     const {
         hoverifier,

src/libs/code_intelligence/search.ts

@@ -62,7 +62,6 @@ import {
 import { featureFlags } from '../../shared/util/featureFlags'
 import { diffDomFunctions, searchCodeSnippetDOMFunctions, singleFileDOMFunctions } from './dom_functions'
 import { injectExtensionsGlobalComponents } from './extensions'
-import { initSearch } from './search'
 import {
     createBlobAnnotatorMount,
     getCodeCommentContainers,
@@ -287,7 +286,6 @@ function inject(): void {
 
     injectMermaid()
 
-    initSearch()
     injectInlineSearch()
 }
 

src/libs/github/inject.tsx

@@ -8,7 +8,6 @@ import {
 import { getCommandPaletteMount } from './extensions'
 import { resolveCommitFileInfo, resolveDiffFileInfo, resolveFileInfo } from './file_info'
 import { getPageInfo, GitLabPageKind } from './scrape'
-import { search } from './search'
 
 const toolbarButtonProps = {
     className: 'btn btn-default btn-sm',
@@ -95,6 +94,5 @@ export const gitlabCodeHost: CodeHost = {
     check: checkIsGitlab,
     codeViewResolver,
     adjustOverlayPosition,
-    search,
     getCommandPaletteMount,
 }

src/libs/github/search.ts

@@ -9,10 +9,6 @@ interface Props {
 }
 
 export class FeatureFlagCard extends React.Component<Props, {}> {
-    private onExecuteSearchToggled = () => {
-        storage.setSync({ executeSearchEnabled: !this.props.storage.executeSearchEnabled })
-    }
-
     private onMermaidToggled = () => {
         const renderMermaidGraphsEnabled = !this.props.storage.renderMermaidGraphsEnabled
         storage.setSync({ renderMermaidGraphsEnabled })
@@ -27,30 +23,14 @@ export class FeatureFlagCard extends React.Component<Props, {}> {
     }
 
     public render(): JSX.Element | null {
-        const {
-            inlineSymbolSearchEnabled,
-            renderMermaidGraphsEnabled,
-            executeSearchEnabled,
-            useExtensions,
-        } = this.props.storage
+        const { inlineSymbolSearchEnabled, renderMermaidGraphsEnabled, useExtensions } = this.props.storage
         return (
             <Row className="pb-3">
                 <Col>
                     <Card>
                         <CardHeader>Feature flags</CardHeader>
                         <CardBody>
                             <Form>
-                                <FormGroup check={true}>
-                                    <Label check={true}>
-                                        <Input
-                                            onClick={this.onExecuteSearchToggled}
-                                            defaultChecked={executeSearchEnabled}
-                                            type="checkbox"
-                                        />{' '}
-                                        Open a new window with Sourcegraph search results when you perform a search on
-                                        your code host.
-                                    </Label>
-                                </FormGroup>
                                 <FormGroup check={true}>
                                     <Label check={true}>
                                         <Input