From 5b68d11d66e4c2efb085795fcfba29b0b460bca5 Mon Sep 17 00:00:00 2001 From: Varun Gandhi Date: Wed, 29 Jun 2022 12:58:28 +0200 Subject: [PATCH 1/2] ci: Add GitHub Action for running SCIP tests. --- .github/workflows/ci.yml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 .github/workflows/ci.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 0000000000..773e41965d --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,23 @@ +name: CI +on: + push: + branches: + - scip-ruby/master + pull_request: + branches: + - scip-ruby/master + +jobs: + test: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - name: Install Bazel + run: sudo npm install --location=global @bazel/bazelisk + - name: Mount bazel cache + uses: actions/cache@v3 + with: + path: "$HOME/.cache/bazel" + key: bazel + - name: Run tests + run: ./bazel test --test_output=errors //test/scip --config=dbg From f2b748a023f9ff53bc42d5cbfc69fc6deb05604c Mon Sep 17 00:00:00 2001 From: Varun Gandhi Date: Wed, 29 Jun 2022 15:03:17 +0200 Subject: [PATCH 2/2] test: path.append joins with a separator. For very C++ reasons, there is also 'concat' which does not add a separator. --- test/scip_test_runner.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/scip_test_runner.cc b/test/scip_test_runner.cc index 3cf7651563..7a49786fcc 100644 --- a/test/scip_test_runner.cc +++ b/test/scip_test_runner.cc @@ -292,7 +292,7 @@ TEST_CASE("SCIPTest") { using Provider = pipeline::semantic_extension::SemanticExtensionProvider; auto indexFilePath = filesystem::temp_directory_path(); - indexFilePath.concat(test.basename + ".scip"); // FIXME(varun): Update for folder tests with multiple files? + indexFilePath.append(test.basename + ".scip"); // FIXME(varun): Update for folder tests with multiple files? auto providers = Provider::getProviders(); ENFORCE(providers.size() == 1);