run modernize -fix

- replace interface{} with any
- use min / max functions
- use fmt.Appendf for byte[] slice creation with strings
- use slices package

Author: burmudar

cmd/src/api.go

@@ -76,7 +76,7 @@ Examples:
 		}
 
 		// Determine which variables to use in the request.
-		vars := map[string]interface{}{}
+		vars := map[string]any{}
 		if *varsFlag != "" {
 			if err := json.Unmarshal([]byte(*varsFlag), &vars); err != nil {
 				return err
@@ -93,7 +93,7 @@ Examples:
 		}
 
 		// Perform the request.
-		var result interface{}
+		var result any
 		if ok, err := cfg.apiClient(apiFlags, flagSet.Output()).NewRequest(query, vars).DoRaw(context.Background(), &result); err != nil || !ok {
 			return err
 		}

cmd/src/cmd.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"log"
 	"os"
+	"slices"
 
 	"github.com/sourcegraph/src-cli/internal/cmderrors"
 )
@@ -30,12 +31,7 @@ func (c *command) matches(name string) bool {
 	if name == c.flagSet.Name() {
 		return true
 	}
-	for _, alias := range c.aliases {
-		if name == alias {
-			return true
-		}
-	}
-	return false
+	return slices.Contains(c.aliases, name)
 }
 
 // commander represents a top-level command with subcommands.
@@ -60,7 +56,6 @@ func (c commander) run(flagSet *flag.FlagSet, cmdName, usageText string, args []
 
 	// Configure default usage funcs for commands.
 	for _, cmd := range c {
-		cmd := cmd
 		if cmd.usageFunc != nil {
 			cmd.flagSet.Usage = cmd.usageFunc
 			continue

cmd/src/code_intel_upload.go

@@ -98,7 +98,7 @@ func handleCodeIntelUpload(args []string) error {
 	}
 
 	if codeintelUploadFlags.json {
-		serialized, err := json.Marshal(map[string]interface{}{
+		serialized, err := json.Marshal(map[string]any{
 			"repo":           codeintelUploadFlags.repo,
 			"commit":         codeintelUploadFlags.commit,
 			"root":           codeintelUploadFlags.root,
@@ -202,7 +202,7 @@ func makeCodeIntelUploadURL(uploadID int) (string, error) {
 		return "", err
 	}
 
-	graphqlID := base64.URLEncoding.EncodeToString([]byte(fmt.Sprintf(`SCIPUpload:%d`, uploadID)))
+	graphqlID := base64.URLEncoding.EncodeToString(fmt.Appendf(nil, `SCIPUpload:%d`, uploadID))
 	url.Path = codeintelUploadFlags.repo + "/-/code-intelligence/uploads/" + graphqlID
 	url.User = nil
 	return url.String(), nil

cmd/src/codeowners_create.go

@@ -88,7 +88,7 @@ Examples:
 		var result struct {
 			AddCodeownersFile CodeownersIngestedFile
 		}
-		if ok, err := client.NewRequest(query, map[string]interface{}{
+		if ok, err := client.NewRequest(query, map[string]any{
 			"repoName": *repoFlag,
 			"content":  string(content),
 		}).Do(context.Background(), &result); err != nil || !ok {

cmd/src/codeowners_delete.go

@@ -57,7 +57,7 @@ Examples:
 		var result struct {
 			DeleteCodeownersFile CodeownersIngestedFile
 		}
-		if ok, err := client.NewRequest(query, map[string]interface{}{
+		if ok, err := client.NewRequest(query, map[string]any{
 			"repoName": *repoFlag,
 		}).Do(context.Background(), &result); err != nil || !ok {
 			var gqlErr api.GraphQlErrors

cmd/src/codeowners_get.go

@@ -59,7 +59,7 @@ Examples:
 				IngestedCodeowners *CodeownersIngestedFile
 			}
 		}
-		if ok, err := client.NewRequest(query, map[string]interface{}{
+		if ok, err := client.NewRequest(query, map[string]any{
 			"repoName": *repoFlag,
 		}).Do(context.Background(), &result); err != nil || !ok {
 			return err

cmd/src/codeowners_update.go

@@ -86,7 +86,7 @@ Examples:
 		var result struct {
 			UpdateCodeownersFile CodeownersIngestedFile
 		}
-		if ok, err := client.NewRequest(query, map[string]interface{}{
+		if ok, err := client.NewRequest(query, map[string]any{
 			"repoName": *repoFlag,
 			"content":  string(content),
 		}).Do(context.Background(), &result); err != nil || !ok {

cmd/src/config.go

@@ -159,7 +159,7 @@ query SettingsSubjectLatestSettingsID($subject: ID!) {
 		}
 	}
 
-	if _, err := client.NewRequest(query, map[string]interface{}{
+	if _, err := client.NewRequest(query, map[string]any{
 		"subject": subjectID,
 	}).Do(ctx, &result); err != nil {
 		return nil, err

cmd/src/config_edit.go

@@ -109,12 +109,12 @@ mutation EditSettings($input: SettingsMutationGroupInput!, $edit: SettingsEdit!)
     }
   }
 }`
-		queryVars := map[string]interface{}{
-			"input": map[string]interface{}{
+		queryVars := map[string]any{
+			"input": map[string]any{
 				"subject": subjectID,
 				"lastID":  lastID,
 			},
-			"edit": map[string]interface{}{
+			"edit": map[string]any{
 				"keyPath":                   keyPath,
 				"value":                     value,
 				"valueIsJSONCEncodedString": true,

cmd/src/config_get.go

@@ -50,12 +50,12 @@ Examples:
 		}
 
 		var query string
-		var queryVars map[string]interface{}
+		var queryVars map[string]any
 		if *subjectFlag == "" {
 			query = viewerSettingsQuery
 		} else {
 			query = settingsSubjectCascadeQuery
-			queryVars = map[string]interface{}{
+			queryVars = map[string]any{
 				"subject": api.NullString(*subjectFlag),
 			}
 		}