From ccd5c99f841186d971488a5f6bd29fc24f440fe7 Mon Sep 17 00:00:00 2001 From: Robert Lin Date: Wed, 11 Jan 2023 17:52:09 -0800 Subject: [PATCH] instancehealth: remove monitoring check --- internal/instancehealth/checks.go | 33 ------------------------------- 1 file changed, 33 deletions(-) diff --git a/internal/instancehealth/checks.go b/internal/instancehealth/checks.go index 0c2e2557ce..f78dd57b0e 100644 --- a/internal/instancehealth/checks.go +++ b/internal/instancehealth/checks.go @@ -2,7 +2,6 @@ package instancehealth import ( "fmt" - "strings" "time" "github.com/sourcegraph/sourcegraph/lib/errors" @@ -31,11 +30,6 @@ func NewChecks( defer b.Close() return checkSiteConfiguration(b, instanceHealth) }, - func(out *output.Output) error { - b := out.Block(output.Styled(output.StyleBold, "Monitoring alerts")) - defer b.Close() - return checkMonitoringAlerts(b, since, instanceHealth) - }, func(out *output.Output) error { b := out.Block(output.Styled(output.StyleBold, "External services")) defer b.Close() @@ -86,33 +80,6 @@ func checkSiteConfiguration( return nil } -// checkMonitoringAlerts indicates if there are any alerts issued by monitoring infra -func checkMonitoringAlerts( - out output.Writer, - since time.Duration, - instanceHealth Indicators, -) error { - var criticalAlerts int - for _, a := range instanceHealth.Site.MonitoringStatistics.Alerts { - if a.Average == 0 || !strings.Contains(strings.ToLower(a.Name), "critical") { - continue - } - // average is ratio of 12h windows that alert was active, so we set the threshold - // if it's possible this alert could have been active in this 'since' window. - if a.Average*0.5 >= since.Hours()/12 { - criticalAlerts += 1 - out.WriteLine(output.Linef(output.EmojiWarning, output.StyleWarning, - "Found recently active alert: %q", a.Name)) - } - } - if criticalAlerts == 0 { - out.WriteLine(output.Emoji(output.EmojiSuccess, "No critical monitoring alerts!")) - } - // never error, just issue printed warning, since critical alerts aren't all _that_ - // reliable today, though they provide a potentially useful signal. - return nil -} - // checkExternalServices checks the health of external service syncing func checkExternalServices( out output.Writer,