From 57a4744e49dd97ae75a0c32248efeeaee5ff48f0 Mon Sep 17 00:00:00 2001 From: Keegan Carruthers-Smith Date: Thu, 16 Feb 2023 15:57:47 +0200 Subject: [PATCH] servegit: use more performant WalkDir WalkDir was introduced in go1.16 suits our use case while being more efficient. Test Plan: go test --- internal/servegit/serve.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/servegit/serve.go b/internal/servegit/serve.go index 4e3b99a2f1..ec45103bca 100644 --- a/internal/servegit/serve.go +++ b/internal/servegit/serve.go @@ -5,10 +5,10 @@ import ( "encoding/json" "fmt" "html/template" + "io/fs" "log" "net" "net/http" - "os" "os/exec" pathpkg "path" "path/filepath" @@ -170,7 +170,7 @@ func (s *Serve) Repos() ([]Repo, error) { return nil, nil } - err = filepath.Walk(root, func(path string, fi os.FileInfo, fileErr error) error { + err = filepath.WalkDir(root, func(path string, fi fs.DirEntry, fileErr error) error { if fileErr != nil { s.Info.Printf("WARN: ignoring error searching %s: %v", path, fileErr) return nil