Workaround for Hibernate bug: setCurrentTenantIdentifierResolver not respected [SPR-14476]

[spring-projects-issues]

Yanming Zhou opened SPR-14476 and commented

Spring should check if
CurrentTenantIdentifierResolver exists when open session.

HibernateTransactionManager:

SessionBuilder builder = getSessionFactory().withOptions();
CurrentTenantIdentifierResolver resolver = ((SessionFactoryImplementor)getSessionFactory()).getCurrentTenantIdentifierResolver();
if ( resolver != null ) {
     builder.tenantIdentifier( resolver.resolveCurrentTenantIdentifier() );
}
Interceptor entityInterceptor = getEntityInterceptor();
if ( entityInterceptor != null ) {
     builder.interceptor( entityInterceptor );
}
Session newSession = builder.openSession();

And other place like OpenSessionInViewFilter should fix also.

BTW: Hibernate has a bug itself, hibernate/hibernate-orm#1483 , Spring can make workaround by override method in LocalSessionFactoryBean

@Override
public void setCurrentTenantIdentifierResolver(CurrentTenantIdentifierResolver currentTenantIdentifierResolver) {
     getHibernateProperties().put(AvailableSettings.MULTI_TENANT_IDENTIFIER_RESOLVER,
               currentTenantIdentifierResolver);
     super.setCurrentTenantIdentifierResolver(currentTenantIdentifierResolver);
}

---

Affects: 4.3.1

Issue Links:

• Add setMultiTenantConnectionProvider to org.springframework.orm.hibernate5.LocalSessionFactoryBean [SPR-14072] #18644 Add setMultiTenantConnectionProvider to org.springframework.orm.hibernate5.LocalSessionFactoryBean

Referenced from: commits 4e7e06f, 1670b4e

[spring-projects-issues]

Juergen Hoeller commented

As far as I'm aware, Hibernate should be doing this automatically when opening a Session, and actually does it in 5.2.1 at least:

https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src/main/java/org/hibernate/internal/SessionFactoryImpl.java#L1094

So Session opening is arguably working as designed. From my perspective, let's reduce this issue to a workaround for the setCurrentTenantIdentifierResolver bug in Hibernate.