From dd1c01ad1463c5dfedd8a3944ec5dc0568d7cdea Mon Sep 17 00:00:00 2001 From: Dan Federman Date: Mon, 20 Jan 2020 10:47:47 -0800 Subject: [PATCH 1/2] Add explicit tests for CloudAccessibility --- .../ValetTests/CloudAccessibilityTests.swift | 37 +++++++++++++++++++ Valet.xcodeproj/project.pbxproj | 8 ++++ 2 files changed, 45 insertions(+) create mode 100644 Tests/ValetTests/CloudAccessibilityTests.swift diff --git a/Tests/ValetTests/CloudAccessibilityTests.swift b/Tests/ValetTests/CloudAccessibilityTests.swift new file mode 100644 index 00000000..78ec9091 --- /dev/null +++ b/Tests/ValetTests/CloudAccessibilityTests.swift @@ -0,0 +1,37 @@ +// Created by Dan Federman on 1/20/20. +// Copyright © 2020 Square, Inc. +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +//    http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. +// + +import Foundation +import XCTest + +@testable import Valet + + +class CloudAccessibilityTests: XCTestCase { + + func test_description_mirrorsAccessibilityCounterpartDescription() { + CloudAccessibility.allValues().forEach { + XCTAssertEqual($0.description, $0.accessibility.description) + } + } + + func test_secAccessibilityAttribute_mirrorsAccessibilityCounterpartSecAccessibilityAttribute() { + CloudAccessibility.allValues().forEach { + XCTAssertEqual($0.secAccessibilityAttribute, $0.accessibility.secAccessibilityAttribute) + } + } + +} diff --git a/Valet.xcodeproj/project.pbxproj b/Valet.xcodeproj/project.pbxproj index b81dd292..514ae846 100644 --- a/Valet.xcodeproj/project.pbxproj +++ b/Valet.xcodeproj/project.pbxproj @@ -132,6 +132,9 @@ 165CDDCB204B26D400C96C2E /* ViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 165CDDCA204B26D400C96C2E /* ViewController.swift */; }; 165CDDCE204B26D400C96C2E /* Main.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 165CDDCC204B26D400C96C2E /* Main.storyboard */; }; 165CDDD0204B26D500C96C2E /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 165CDDCF204B26D500C96C2E /* Assets.xcassets */; }; + 167E250723D62CAA00889121 /* CloudAccessibilityTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 167E250623D62CAA00889121 /* CloudAccessibilityTests.swift */; }; + 167E250823D62CAA00889121 /* CloudAccessibilityTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 167E250623D62CAA00889121 /* CloudAccessibilityTests.swift */; }; + 167E250923D62CAA00889121 /* CloudAccessibilityTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 167E250623D62CAA00889121 /* CloudAccessibilityTests.swift */; }; 168909381F7199D60057F636 /* Valet.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 26E6827C1BA8B3F900EFF4EA /* Valet.framework */; }; 168909391F7199D60057F636 /* Valet.framework in Embed Frameworks */ = {isa = PBXBuildFile; fileRef = 26E6827C1BA8B3F900EFF4EA /* Valet.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; }; 169E9A6723D181DC001B69F5 /* VALSinglePromptSecureEnclaveValetTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 169E9A6423D181DC001B69F5 /* VALSinglePromptSecureEnclaveValetTests.m */; }; @@ -405,6 +408,7 @@ 165CDDCF204B26D500C96C2E /* Assets.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = Assets.xcassets; sourceTree = ""; }; 165CDDD1204B26D500C96C2E /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = ""; }; 165CDDD5204B26F700C96C2E /* Valet tvOS Test Host App.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.plist.entitlements; path = "Valet tvOS Test Host App.entitlements"; sourceTree = ""; }; + 167E250623D62CAA00889121 /* CloudAccessibilityTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = CloudAccessibilityTests.swift; sourceTree = ""; }; 169E9A6423D181DC001B69F5 /* VALSinglePromptSecureEnclaveValetTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = VALSinglePromptSecureEnclaveValetTests.m; sourceTree = ""; }; 169E9A6523D181DC001B69F5 /* VALValetTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = VALValetTests.m; sourceTree = ""; }; 169E9A6623D181DC001B69F5 /* VALSecureEnclaveValetTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = VALSecureEnclaveValetTests.m; sourceTree = ""; }; @@ -593,6 +597,7 @@ 1612FD0922A9C95500FC1142 /* ValetTests */ = { isa = PBXGroup; children = ( + 167E250623D62CAA00889121 /* CloudAccessibilityTests.swift */, 1612FD0A22A9C95500FC1142 /* SinglePromptSecureEnclaveTests.swift */, 1612FD0B22A9C95500FC1142 /* SecureEnclaveTests.swift */, 1612FD0C22A9C95500FC1142 /* CloudTests.swift */, @@ -1549,6 +1554,7 @@ 1612FD3422A9C95500FC1142 /* CloudTests.swift in Sources */, 32E7115E2336B90800018E15 /* SinglePromptSecureEnclaveTests.swift in Sources */, 169E9A6923D181DC001B69F5 /* VALSinglePromptSecureEnclaveValetTests.m in Sources */, + 167E250923D62CAA00889121 /* CloudAccessibilityTests.swift in Sources */, 169E9A6F23D181DC001B69F5 /* VALSecureEnclaveValetTests.m in Sources */, ); runOnlyForDeploymentPostprocessing = 0; @@ -1653,6 +1659,7 @@ 1612FD2622A9C95500FC1142 /* ValetIntegrationTests.swift in Sources */, 1612FD2022A9C95500FC1142 /* ValetBackwardsCompatibilityTests.swift in Sources */, 169E9A6D23D181DC001B69F5 /* VALSecureEnclaveValetTests.m in Sources */, + 167E250723D62CAA00889121 /* CloudAccessibilityTests.swift in Sources */, 1612FD1A22A9C95500FC1142 /* SynchronizableBackwardsCompatibilityTests.swift in Sources */, ); runOnlyForDeploymentPostprocessing = 0; @@ -1671,6 +1678,7 @@ 1612FD3022A9C95500FC1142 /* SecureEnclaveTests.swift in Sources */, 1612FD3322A9C95500FC1142 /* CloudTests.swift in Sources */, 1612FD3822A9C96900FC1142 /* MacTests.swift in Sources */, + 167E250823D62CAA00889121 /* CloudAccessibilityTests.swift in Sources */, 1612FD2D22A9C95500FC1142 /* SinglePromptSecureEnclaveTests.swift in Sources */, 169E9A6823D181DC001B69F5 /* VALSinglePromptSecureEnclaveValetTests.m in Sources */, 169E9A6E23D181DC001B69F5 /* VALSecureEnclaveValetTests.m in Sources */, From 1dbf32ee738db0b80db182faaa5d07a33e35b971 Mon Sep 17 00:00:00 2001 From: Dan Federman Date: Mon, 20 Jan 2020 19:10:41 -0800 Subject: [PATCH 2/2] Make test class final --- Tests/ValetTests/CloudAccessibilityTests.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Tests/ValetTests/CloudAccessibilityTests.swift b/Tests/ValetTests/CloudAccessibilityTests.swift index 78ec9091..fa5532bf 100644 --- a/Tests/ValetTests/CloudAccessibilityTests.swift +++ b/Tests/ValetTests/CloudAccessibilityTests.swift @@ -20,7 +20,7 @@ import XCTest @testable import Valet -class CloudAccessibilityTests: XCTestCase { +final class CloudAccessibilityTests: XCTestCase { func test_description_mirrorsAccessibilityCounterpartDescription() { CloudAccessibility.allValues().forEach {