From de94d6545c2b7a44348a053d8e83caffc910cf0b Mon Sep 17 00:00:00 2001 From: Nick Larsen Date: Tue, 4 Nov 2025 13:17:49 +0100 Subject: [PATCH 1/5] Replace warning level with warn. --- .../pages/observability/telemetry.adoc | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/modules/concepts/pages/observability/telemetry.adoc b/modules/concepts/pages/observability/telemetry.adoc index 3acba8bc4..da694758c 100644 --- a/modules/concepts/pages/observability/telemetry.adoc +++ b/modules/concepts/pages/observability/telemetry.adoc @@ -46,9 +46,9 @@ telemetry: format: null # <3> ---- -<1> Boolean: `true, false` -<2> Enum: `error, warning, info, debug, trace` -<3> Enum: `plain, json` +<1> Boolean: `true`, `false` +<2> Enum: `error`, `warn`, `info`, `debug`, trace` +<3> Enum: `plain`, `json` == File logs @@ -65,9 +65,9 @@ telemetry: maxFiles: 6 # <4> ---- -<1> Boolean: `true, false` -<2> Enum: `error, warning, info, debug, trace` -<3> Enum: `never, daily, hourly, minutely` +<1> Boolean: `true`, `false` +<2> Enum: `error`, `warn`, `info`, `debug`, `trace` +<3> Enum: `never`, `daily`, `hourly`, `minutely` <4> Unsigned Integer == OpenTelemetry logs and traces @@ -88,6 +88,6 @@ telemetry: endpoint: null # <3> ---- -<1> Boolean: `true, false` -<2> Enum: `error, warning, info, debug, trace` -<3> String: E.g. `my-collector:4317` +<1> Boolean: `true`, `false` +<2> Enum: `error`, `warn`, `info`, `debug`, `trace` +<3> String: E.g. `https://my-collector:4317` (Note: it must contain the scheme) From c0cfa200c0558c53796d5a2dc4d75888c5199f3a Mon Sep 17 00:00:00 2001 From: Nick Larsen Date: Tue, 4 Nov 2025 13:24:10 +0100 Subject: [PATCH 2/5] Update help for telemetry level filters --- modules/concepts/pages/observability/telemetry.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/concepts/pages/observability/telemetry.adoc b/modules/concepts/pages/observability/telemetry.adoc index da694758c..44a8be95d 100644 --- a/modules/concepts/pages/observability/telemetry.adoc +++ b/modules/concepts/pages/observability/telemetry.adoc @@ -47,7 +47,7 @@ telemetry: ---- <1> Boolean: `true`, `false` -<2> Enum: `error`, `warn`, `info`, `debug`, trace` +<2> String: `error`, `warn`, `info`, `debug`, `trace`, `off` (and https://rustc-dev-guide.rust-lang.org/tracing.html#query-level-filters[more complex filters]) <3> Enum: `plain`, `json` == File logs @@ -66,7 +66,7 @@ telemetry: ---- <1> Boolean: `true`, `false` -<2> Enum: `error`, `warn`, `info`, `debug`, `trace` +<2> String: `error`, `warn`, `info`, `debug`, `trace`, `off` (and https://rustc-dev-guide.rust-lang.org/tracing.html#query-level-filters[more complex filters]) <3> Enum: `never`, `daily`, `hourly`, `minutely` <4> Unsigned Integer @@ -89,5 +89,5 @@ telemetry: ---- <1> Boolean: `true`, `false` -<2> Enum: `error`, `warn`, `info`, `debug`, `trace` +<2> String: `error`, `warn`, `info`, `debug`, `trace`, `off` (and https://rustc-dev-guide.rust-lang.org/tracing.html#query-level-filters[more complex filters]) <3> String: E.g. `https://my-collector:4317` (Note: it must contain the scheme) From c9eb595bffb51b1721406dcee5d818409897b315 Mon Sep 17 00:00:00 2001 From: Nick Larsen Date: Tue, 4 Nov 2025 13:34:39 +0100 Subject: [PATCH 3/5] Update URL for directives --- modules/concepts/pages/observability/telemetry.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/concepts/pages/observability/telemetry.adoc b/modules/concepts/pages/observability/telemetry.adoc index 44a8be95d..2e22b6d9f 100644 --- a/modules/concepts/pages/observability/telemetry.adoc +++ b/modules/concepts/pages/observability/telemetry.adoc @@ -47,7 +47,7 @@ telemetry: ---- <1> Boolean: `true`, `false` -<2> String: `error`, `warn`, `info`, `debug`, `trace`, `off` (and https://rustc-dev-guide.rust-lang.org/tracing.html#query-level-filters[more complex filters]) +<2> String: `error`, `warn`, `info`, `debug`, `trace`, `off` (or https://docs.rs/tracing-subscriber/latest/tracing_subscriber/filter/struct.EnvFilter.html#example-syntax[more complex filters]) <3> Enum: `plain`, `json` == File logs @@ -66,7 +66,7 @@ telemetry: ---- <1> Boolean: `true`, `false` -<2> String: `error`, `warn`, `info`, `debug`, `trace`, `off` (and https://rustc-dev-guide.rust-lang.org/tracing.html#query-level-filters[more complex filters]) +<2> String: `error`, `warn`, `info`, `debug`, `trace`, `off` (or https://docs.rs/tracing-subscriber/latest/tracing_subscriber/filter/struct.EnvFilter.html#example-syntax[more complex filters]) <3> Enum: `never`, `daily`, `hourly`, `minutely` <4> Unsigned Integer @@ -89,5 +89,5 @@ telemetry: ---- <1> Boolean: `true`, `false` -<2> String: `error`, `warn`, `info`, `debug`, `trace`, `off` (and https://rustc-dev-guide.rust-lang.org/tracing.html#query-level-filters[more complex filters]) +<2> String: `error`, `warn`, `info`, `debug`, `trace`, `off` (or https://docs.rs/tracing-subscriber/latest/tracing_subscriber/filter/struct.EnvFilter.html#example-syntax[more complex filters]) <3> String: E.g. `https://my-collector:4317` (Note: it must contain the scheme) From ee95f36497018c940af9790cccd6f16c1a2a55c2 Mon Sep 17 00:00:00 2001 From: Nick Larsen Date: Tue, 4 Nov 2025 13:36:06 +0100 Subject: [PATCH 4/5] Use a link variable --- modules/concepts/pages/observability/telemetry.adoc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/modules/concepts/pages/observability/telemetry.adoc b/modules/concepts/pages/observability/telemetry.adoc index 2e22b6d9f..dd2d6f0f1 100644 --- a/modules/concepts/pages/observability/telemetry.adoc +++ b/modules/concepts/pages/observability/telemetry.adoc @@ -1,4 +1,5 @@ = Telemetry signals in operators +:env-filter-syntax: https://docs.rs/tracing-subscriber/latest/tracing_subscriber/filter/struct.EnvFilter.html#example-syntax [NOTE] ==== @@ -47,7 +48,7 @@ telemetry: ---- <1> Boolean: `true`, `false` -<2> String: `error`, `warn`, `info`, `debug`, `trace`, `off` (or https://docs.rs/tracing-subscriber/latest/tracing_subscriber/filter/struct.EnvFilter.html#example-syntax[more complex filters]) +<2> String: `error`, `warn`, `info`, `debug`, `trace`, `off` (or {env-filter-syntax}[more complex filters]) <3> Enum: `plain`, `json` == File logs @@ -66,7 +67,7 @@ telemetry: ---- <1> Boolean: `true`, `false` -<2> String: `error`, `warn`, `info`, `debug`, `trace`, `off` (or https://docs.rs/tracing-subscriber/latest/tracing_subscriber/filter/struct.EnvFilter.html#example-syntax[more complex filters]) +<2> String: `error`, `warn`, `info`, `debug`, `trace`, `off` (or {env-filter-syntax}[more complex filters]) <3> Enum: `never`, `daily`, `hourly`, `minutely` <4> Unsigned Integer @@ -89,5 +90,5 @@ telemetry: ---- <1> Boolean: `true`, `false` -<2> String: `error`, `warn`, `info`, `debug`, `trace`, `off` (or https://docs.rs/tracing-subscriber/latest/tracing_subscriber/filter/struct.EnvFilter.html#example-syntax[more complex filters]) +<2> String: `error`, `warn`, `info`, `debug`, `trace`, `off` (or {env-filter-syntax}[more complex filters]) <3> String: E.g. `https://my-collector:4317` (Note: it must contain the scheme) From af0cd3a3b99cc429103ece4bccc4176844a40984 Mon Sep 17 00:00:00 2001 From: Nick Larsen Date: Tue, 4 Nov 2025 13:38:54 +0100 Subject: [PATCH 5/5] Open link in new tab I chose not to move the title `[]` bit to the url definition so that it still reads well as text --- modules/concepts/pages/observability/telemetry.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/concepts/pages/observability/telemetry.adoc b/modules/concepts/pages/observability/telemetry.adoc index dd2d6f0f1..84d3c15af 100644 --- a/modules/concepts/pages/observability/telemetry.adoc +++ b/modules/concepts/pages/observability/telemetry.adoc @@ -48,7 +48,7 @@ telemetry: ---- <1> Boolean: `true`, `false` -<2> String: `error`, `warn`, `info`, `debug`, `trace`, `off` (or {env-filter-syntax}[more complex filters]) +<2> String: `error`, `warn`, `info`, `debug`, `trace`, `off` (or {env-filter-syntax}[more complex filters,window=_blank]) <3> Enum: `plain`, `json` == File logs @@ -67,7 +67,7 @@ telemetry: ---- <1> Boolean: `true`, `false` -<2> String: `error`, `warn`, `info`, `debug`, `trace`, `off` (or {env-filter-syntax}[more complex filters]) +<2> String: `error`, `warn`, `info`, `debug`, `trace`, `off` (or {env-filter-syntax}[more complex filters,window=_blank]) <3> Enum: `never`, `daily`, `hourly`, `minutely` <4> Unsigned Integer @@ -90,5 +90,5 @@ telemetry: ---- <1> Boolean: `true`, `false` -<2> String: `error`, `warn`, `info`, `debug`, `trace`, `off` (or {env-filter-syntax}[more complex filters]) +<2> String: `error`, `warn`, `info`, `debug`, `trace`, `off` (or {env-filter-syntax}[more complex filters,window=_blank]) <3> String: E.g. `https://my-collector:4317` (Note: it must contain the scheme)