Skip to content

Comments

[WIP] update mcm setup with the existing stackit setup#69

Closed
aniruddha2000 wants to merge 17 commits intomainfrom
ani/mcm-stackit
Closed

[WIP] update mcm setup with the existing stackit setup#69
aniruddha2000 wants to merge 17 commits intomainfrom
ani/mcm-stackit

Conversation

@aniruddha2000
Copy link
Member

@aniruddha2000 aniruddha2000 commented Dec 10, 2025

How to categorize this PR?

What this PR does / why we need it:
/kind enhancement
Special notes for your reviewer:

Breaking changes:

fixes 5239

@ske-prow ske-prow bot added kind/enhancement Enhancement, improvement, extension do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 10, 2025
@ske-prow
Copy link

ske-prow bot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign breuerfelix for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 10, 2025
@ske-prow ske-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2025
@dergeberl dergeberl mentioned this pull request Dec 12, 2025
Merged
nschad
nschad reviewed Dec 12, 2025
View reviewed changes
pkg/provider/sdk_client.go Outdated
// Configure SDK with custom base URL if provided (for testing with mock server)
baseURL := os.Getenv("STACKIT_API_ENDPOINT")
// baseURL := os.Getenv("STACKIT_API_ENDPOINT")
// TODO: this should be configureable via ske-tages or ske-base
Copy link
Contributor

@nschad nschad Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: Configured here

https://github.com/stackitcloud/ske-base/blob/96054b75e9e18cd9a1fd2eb936b0e80353151776/deploy/initial/gardener-extensions/provider-stackit.yaml#L49-L53

Just needs to passed down from the provider-stackit or somehow else

Copy link
Contributor

@nschad nschad Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

via the webhook here: https://github.com/stackitcloud/gardener-extension-provider-stackit/blob/dc4753c05f096b70b942988da996437b8e801b0d/pkg/webhook/controlplane/ensurer.go#L53

@aniruddha2000 aniruddha2000 force-pushed the ani/mcm-stackit branch 2 times, most recently from 4f51a0d to b4e0778 Compare December 18, 2025 08:28
@ske-prow ske-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2025
@ske-prow ske-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 19, 2025
@ske-prow
Copy link

ske-prow bot commented Dec 19, 2025

@aniruddha2000: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-machine-controller-manager-provider-stackit-verify 3774f29 link true /test pull-machine-controller-manager-provider-stackit-verify

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see the gardener testing guideline for how to avoid and hunt flakes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ske-prow ske-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 22, 2025
@ske-prow
Copy link

ske-prow bot commented Dec 22, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@breuerfelix
Copy link
Member

breuerfelix commented Dec 22, 2025

closed. Got implemented in multiple minor PRs

@breuerfelix breuerfelix deleted the ani/mcm-stackit branch February 18, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nschad nschad nschad left review comments

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement Enhancement, improvement, extension needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aniruddha2000 @breuerfelix @nschad