Skip to content

Comments

wait for server to be ACTIVE#99

Merged
ske-prow[bot] merged 2 commits intomainfrom
wait-for-server
Feb 5, 2026
Merged

wait for server to be ACTIVE#99
ske-prow[bot] merged 2 commits intomainfrom
wait-for-server

Conversation

@breuerfelix
Copy link
Member

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:
Part of STACKITSKE-6014.
We need to wait until the machine is ACTIVE in order to properly pass error messages to the customer. Otherwise ResourceExhausted errors will not reach the customer and the Machine will also be in CrashLoopBackoff even though it is just being created due to race conditions when patching the NICs.

Special notes for your reviewer:

Breaking changes:

@ske-prow ske-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement Enhancement, improvement, extension size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 27, 2026
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
@ske-prow ske-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 28, 2026
@breuerfelix breuerfelix force-pushed the wait-for-server branch 3 times, most recently from f50bf85 to b6f5b5e Compare January 28, 2026 13:18
@breuerfelix
Copy link
Member Author

image

Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
@breuerfelix breuerfelix changed the title WIP: wait for server to be ACTIVE wait for server to be ACTIVE Jan 28, 2026
@ske-prow ske-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2026
@nschad
Copy link
Contributor

nschad commented Jan 30, 2026

/lgtm

@ske-prow ske-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2026
@ske-prow
Copy link

ske-prow bot commented Jan 30, 2026

LGTM label has been added.

DetailsGit tree hash: 22965ff4833976132a6de165c47f2e06c1a271cb

@breuerfelix
Copy link
Member Author

/approve

@ske-prow
Copy link

ske-prow bot commented Jan 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breuerfelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2026
@breuerfelix
Copy link
Member Author

breuerfelix commented Jan 30, 2026

/hold

until we tested quota exceeded

@ske-prow ske-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2026
@breuerfelix
Copy link
Member Author

image /unhold

quota exceeded also return Resource Exhausted

@ske-prow ske-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2026
@ske-prow ske-prow bot merged commit 4ddeabd into main Feb 5, 2026
3 checks passed
@breuerfelix breuerfelix deleted the wait-for-server branch February 18, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants