From 4916b7393722d95ecab31fd5199c8a48b71851de Mon Sep 17 00:00:00 2001 From: Claude Date: Mon, 18 May 2026 13:26:20 +0000 Subject: [PATCH 1/2] docs: correct return-value note in `blas/ext/base/*index-of-column` Propagates fix from a6856ed70 ("docs: update notes") to sibling index-of-column packages. The JSDoc and TypeScript notes incorrectly stated the function returns `-1` when "unable to find a search vector" rather than "unable to find a matching column"; the search vector is an always-provided input, so the function instead fails to locate a matching column. --- .../blas/ext/base/gindex-of-column/docs/types/index.d.ts | 6 +++--- .../@stdlib/blas/ext/base/gindex-of-column/lib/accessors.js | 2 +- .../@stdlib/blas/ext/base/gindex-of-column/lib/base.js | 2 +- .../@stdlib/blas/ext/base/gindex-of-column/lib/main.js | 2 +- .../@stdlib/blas/ext/base/gindex-of-column/lib/ndarray.js | 2 +- .../blas/ext/base/sindex-of-column/docs/types/index.d.ts | 6 +++--- .../@stdlib/blas/ext/base/sindex-of-column/lib/ndarray.js | 2 +- .../blas/ext/base/sindex-of-column/lib/sindex_of_column.js | 2 +- 8 files changed, 12 insertions(+), 12 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/gindex-of-column/docs/types/index.d.ts b/lib/node_modules/@stdlib/blas/ext/base/gindex-of-column/docs/types/index.d.ts index c57e7aef71e9..93eac7e5cb42 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gindex-of-column/docs/types/index.d.ts +++ b/lib/node_modules/@stdlib/blas/ext/base/gindex-of-column/docs/types/index.d.ts @@ -37,7 +37,7 @@ interface Routine { * * ## Notes * - * - If the function is provided an empty matrix or if the function is unable to find a search vector, the function returns `-1` (i.e., an invalid index). + * - If the function is provided an empty matrix or if the function is unable to find a matching column, the function returns `-1` (i.e., an invalid index). * * @param order - storage layout * @param M - number of rows in `A` @@ -62,7 +62,7 @@ interface Routine { * * ## Notes * - * - If the function is provided an empty matrix or if the function is unable to find a search vector, the function returns `-1` (i.e., an invalid index). + * - If the function is provided an empty matrix or if the function is unable to find a matching column, the function returns `-1` (i.e., an invalid index). * * @param M - number of rows in `A` * @param N - number of columns in `A` @@ -89,7 +89,7 @@ interface Routine { * * ## Notes * -* - If the function is provided an empty matrix or if the function is unable to find a search vector, the function returns `-1` (i.e., an invalid index). +* - If the function is provided an empty matrix or if the function is unable to find a matching column, the function returns `-1` (i.e., an invalid index). * * @param order - storage layout * @param M - number of rows in `A` diff --git a/lib/node_modules/@stdlib/blas/ext/base/gindex-of-column/lib/accessors.js b/lib/node_modules/@stdlib/blas/ext/base/gindex-of-column/lib/accessors.js index 13ef44a3091c..9cb89eb292f6 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gindex-of-column/lib/accessors.js +++ b/lib/node_modules/@stdlib/blas/ext/base/gindex-of-column/lib/accessors.js @@ -31,7 +31,7 @@ var ones = require( '@stdlib/array/base/ones' ); * * ## Notes * -* - If the function is unable to find a search vector, the function returns `-1` (i.e., an invalid index). +* - If the function is unable to find a matching column, the function returns `-1` (i.e., an invalid index). * * @private * @param {PositiveInteger} M - number of rows in `A` diff --git a/lib/node_modules/@stdlib/blas/ext/base/gindex-of-column/lib/base.js b/lib/node_modules/@stdlib/blas/ext/base/gindex-of-column/lib/base.js index 97c8e3f47f32..3da2e8fb2b2a 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gindex-of-column/lib/base.js +++ b/lib/node_modules/@stdlib/blas/ext/base/gindex-of-column/lib/base.js @@ -33,7 +33,7 @@ var accessors = require( './accessors.js' ); * * ## Notes * -* - If the function is provided an empty matrix or if the function is unable to find a search vector, the function returns `-1` (i.e., an invalid index). +* - If the function is provided an empty matrix or if the function is unable to find a matching column, the function returns `-1` (i.e., an invalid index). * * @private * @param {PositiveInteger} M - number of rows in `A` diff --git a/lib/node_modules/@stdlib/blas/ext/base/gindex-of-column/lib/main.js b/lib/node_modules/@stdlib/blas/ext/base/gindex-of-column/lib/main.js index 0d51f86097bb..76deffae2a71 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gindex-of-column/lib/main.js +++ b/lib/node_modules/@stdlib/blas/ext/base/gindex-of-column/lib/main.js @@ -36,7 +36,7 @@ var base = require( './base.js' ); * * ## Notes * -* - If the function is provided an empty matrix or if the function is unable to find a search vector, the function returns `-1` (i.e., an invalid index). +* - If the function is provided an empty matrix or if the function is unable to find a matching column, the function returns `-1` (i.e., an invalid index). * * @param {string} order - storage layout * @param {PositiveInteger} M - number of rows in `A` diff --git a/lib/node_modules/@stdlib/blas/ext/base/gindex-of-column/lib/ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/gindex-of-column/lib/ndarray.js index 73b3c5b44bd1..68a4a8e5e597 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gindex-of-column/lib/ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/gindex-of-column/lib/ndarray.js @@ -30,7 +30,7 @@ var base = require( './base.js' ); * * ## Notes * -* - If the function is provided an empty matrix or if the function is unable to find a search vector, the function returns `-1` (i.e., an invalid index). +* - If the function is provided an empty matrix or if the function is unable to find a matching column, the function returns `-1` (i.e., an invalid index). * * @param {PositiveInteger} M - number of rows in `A` * @param {PositiveInteger} N - number of columns in `A` diff --git a/lib/node_modules/@stdlib/blas/ext/base/sindex-of-column/docs/types/index.d.ts b/lib/node_modules/@stdlib/blas/ext/base/sindex-of-column/docs/types/index.d.ts index df901082c703..23e9a577e099 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sindex-of-column/docs/types/index.d.ts +++ b/lib/node_modules/@stdlib/blas/ext/base/sindex-of-column/docs/types/index.d.ts @@ -31,7 +31,7 @@ interface Routine { * * ## Notes * - * - If the function is provided an empty matrix or if the function is unable to find a search vector, the function returns `-1` (i.e., an invalid index). + * - If the function is provided an empty matrix or if the function is unable to find a matching column, the function returns `-1` (i.e., an invalid index). * - The `workspace` array is only applicable when an input matrix is stored in row-major order. When the matrix is stored in column-major order, the workspace array is ignored. * * @param order - storage layout @@ -63,7 +63,7 @@ interface Routine { * * ## Notes * - * - If the function is provided an empty matrix or if the function is unable to find a search vector, the function returns `-1` (i.e., an invalid index). + * - If the function is provided an empty matrix or if the function is unable to find a matching column, the function returns `-1` (i.e., an invalid index). * - The `workspace` array is only applicable when an input matrix is stored in row-major order. When the matrix is stored in column-major order, the workspace array is ignored. * * @param M - number of rows in `A` @@ -99,7 +99,7 @@ interface Routine { * * ## Notes * -* - If the function is provided an empty matrix or if the function is unable to find a search vector, the function returns `-1` (i.e., an invalid index). +* - If the function is provided an empty matrix or if the function is unable to find a matching column, the function returns `-1` (i.e., an invalid index). * - The `workspace` array is only applicable when an input matrix is stored in row-major order. When the matrix is stored in column-major order, the workspace array is ignored. * * @param order - storage layout diff --git a/lib/node_modules/@stdlib/blas/ext/base/sindex-of-column/lib/ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/sindex-of-column/lib/ndarray.js index da25cd9012e7..2c664ce88e92 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sindex-of-column/lib/ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sindex-of-column/lib/ndarray.js @@ -32,7 +32,7 @@ var isColumnMajor = require( '@stdlib/ndarray/base/assert/is-column-major' ); * * ## Notes * -* - If the function is provided an empty matrix or if the function is unable to find a search vector, the function returns `-1` (i.e., an invalid index). +* - If the function is provided an empty matrix or if the function is unable to find a matching column, the function returns `-1` (i.e., an invalid index). * - The `workspace` array is only applicable when an input matrix is stored in row-major order. When the matrix is stored in column-major order, the workspace array is ignored. * * @param {PositiveInteger} M - number of rows in `A` diff --git a/lib/node_modules/@stdlib/blas/ext/base/sindex-of-column/lib/sindex_of_column.js b/lib/node_modules/@stdlib/blas/ext/base/sindex-of-column/lib/sindex_of_column.js index 529329528f0c..9ec5cdeab99f 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/sindex-of-column/lib/sindex_of_column.js +++ b/lib/node_modules/@stdlib/blas/ext/base/sindex-of-column/lib/sindex_of_column.js @@ -36,7 +36,7 @@ var ndarray = require( './ndarray.js' ); * * ## Notes * -* - If the function is provided an empty matrix or if the function is unable to find a search vector, the function returns `-1` (i.e., an invalid index). +* - If the function is provided an empty matrix or if the function is unable to find a matching column, the function returns `-1` (i.e., an invalid index). * - The `workspace` array is only applicable when an input matrix is stored in row-major order. When the matrix is stored in column-major order, the workspace array is ignored. * * @param {string} order - storage layout From d47f10c8d219b7ea4084cab3f769bd2591086c8c Mon Sep 17 00:00:00 2001 From: Claude Date: Mon, 18 May 2026 13:26:26 +0000 Subject: [PATCH 2/2] test: fix grammar in test description in `ndarray/empty-like` Propagates fix from 435de1206 ("test: fix grammar in description") to a sibling -like package having the same singular/plural disagreement ("array" vs. "arrays") in a test description. --- lib/node_modules/@stdlib/ndarray/empty-like/test/test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/ndarray/empty-like/test/test.js b/lib/node_modules/@stdlib/ndarray/empty-like/test/test.js index 38b9d806b39f..4d6117830f7b 100644 --- a/lib/node_modules/@stdlib/ndarray/empty-like/test/test.js +++ b/lib/node_modules/@stdlib/ndarray/empty-like/test/test.js @@ -826,7 +826,7 @@ tape( 'the function returns a zero-filled array (dtype=generic, options)', funct t.end(); }); -tape( 'the function guards against array having shapes containing negative dimension sizes', function test( t ) { +tape( 'the function guards against arrays having shapes containing negative dimension sizes', function test( t ) { var x = { 'data': [ 1, 2, 3, 4 ], 'ndims': 3,